Code

feat: Format strings for prints #1952

Code

Merged

jfecher merged 67 commits intomasternoir-lang/noir:masterfrom mv/format-stringnoir-lang/noir:mv/format-stringCopy head branch name to clipboardAug 1, 2023

+414-42

Commits

Commits on Jul 11, 2023

• initial stdlib methods to start refactoring logign

  vezenovm

  committed
  730c9ff

• foreign call enum

  vezenovm

  committed
  d75aedb

• Merge branch 'master' into mv/brillig_logs

  vezenovm

  committed
  f28b915

Commits on Jul 12, 2023

• working println and println_format w/ brillig oracles

  vezenovm

  committed
  ce082b6

• merge conflicts w/ master

  vezenovm

  committed
  4501b69

• fix up brillig_oracle test

  vezenovm

  committed
  44ef833

• uncomment regression test for slice return from foreign calls in brillig

  vezenovm

  committed
  e9f6488

• cargo clippy

  vezenovm

  committed
  e457faf

Commits on Jul 13, 2023

• got structs serialized correctly without aos_to_soa

  vezenovm

  committed
  7cb1b10

• remove dbg

  vezenovm

  committed
  c7e4f0a

• working println_format

  vezenovm

  committed
  1c64aff

• merge conflicts w/ master

  vezenovm

  committed
  e3d8931

• cargo clippy

  vezenovm

  committed
  5c24bf7

• rename enable_slices to experimental_ssa

  vezenovm

  committed
  f4b17d4

• remove dbg and fix format_field_string

  vezenovm

  committed
  d2065ea

Commits on Jul 14, 2023

• initial work towards FmtStr literal

  vezenovm

  committed
  b1739c0

Commits on Jul 17, 2023

• working format strins with one unified println method, still have some cleanup to-do, use Display/Debug for pretty printing

  vezenovm

  committed
  613c94b

Commits on Jul 18, 2023

• remove old comment

  vezenovm

  committed
  2d459a7

• moved resolution of string to fmt string only when passing literals to functions

  vezenovm

  committed
  8b5c523

• delete temp intrinsic for println new

  vezenovm

  committed
  fd59219

• remove unnecessary subtype

  vezenovm

  committed
  9a7519b

• remove debugging code w/ def id as part of mono pass Ident

  vezenovm

  committed
  ff1d406

• cleanup formatting stuff

  vezenovm

  committed
  4a2c098

• master conflicts

  vezenovm

  committed
  3623283

• merge conflcits w/ mv/brillig_logs after master merge

  vezenovm

  committed
  5b27b77

• cargo clippy

  vezenovm

  committed
  ff34dd0

• resolver test for fmt string

  vezenovm

  committed
  2288149

• remove TODO comment

  vezenovm

  committed
  a0df28c

• cargo clippy

  vezenovm

  committed
  6c70d1f

Commits on Jul 19, 2023

• pr comments

  vezenovm

  committed
  5e6d0d5

Commits on Jul 24, 2023

• merge conflicts w/ master after brillig println merge

  vezenovm

  committed
  77c771c

• Merge branch 'master' into mv/format-string

  vezenovm

  committed
  2ebd23a

• expose full fmtstr type to the user

  vezenovm

  committed
  f19b1d4

• add back fmt string resolver test

  vezenovm

  committed
  4615225

• don't allow comparison of format strings

  vezenovm

  committed
  0adca79

• use JsonType Display trait

  vezenovm

  committed
  0572d74

• add issue for printing func params

  vezenovm

  committed
  bba1ed0

• remove Token::F variant

  vezenovm

  committed
  1cd2881

• remove old append_abi_arg func

  vezenovm

  committed
  f953f29

• add comments to append_abi-arg

  vezenovm

  committed
  46240be

• fix: format printing function parameters, store exprs rather than idents as part of HirLiteral::FmtStr

  vezenovm

  committed
  692f85e

Commits on Jul 25, 2023

• remove ve old comment about not being able to use witness values in fmt strings

  vezenovm

  committed
  741ef8b

• push fix for asfs{x}{x} case and more specific regex for idents

  vezenovm

  committed
  009279e

• Update crates/noirc_evaluator/src/ssa_refactor/ssa_gen/mod.rs

  Show description for 643fca5
  

  vezenovm

  and

  jfecher

  authored
  643fca5

• remove is_match check

  vezenovm

  committed
  fa35f1b

• breakout literal fmt str case in resolver to its own func

  vezenovm

  committed
  c783a3b

• update resolve_fmt_strings test

  vezenovm

  committed
  515ef1e

• switch to_owned placement in resolve_fmt_str_literal

  vezenovm

  committed
  a701fb8

• Update crates/noirc_frontend/src/ast/mod.rs

  Show description for 3dc2c83
  

  vezenovm

  and

  jfecher

  authored
  3dc2c83

• fix find_numeric_generics_in_type

  vezenovm

  committed
  a7fa482

• add case of fmt string in if statement

  vezenovm

  committed
  9971fac

• add contains_numeric_typevar cases for string and fmtstring

  vezenovm

  committed
  a97f251

• add unify and subtype checks and fix resolver fmt string test

  vezenovm

  committed
  927abfe

Commits on Jul 31, 2023

• merge conflicts w/ master and cargo fmt

  vezenovm

  committed
  b30c543

• working generic fmtstr types

  vezenovm

  committed
  5c2fddd

Commits on Aug 1, 2023

• separate fmtstr codegen into variables

  vezenovm

  committed
  02ed2b8

• Update crates/noirc_frontend/src/parser/parser.rs

  jfecher

  authored
  0556ca3

• Update crates/noirc_abi/src/input_parser/json.rs

  Show description for 9c84e21
  

  vezenovm

  and

  jfecher

  authored
  9c84e21

• Update crates/noirc_frontend/src/ast/mod.rs

  Show description for 9d320f7
  

  vezenovm

  and

  jfecher

  authored
  9d320f7

• Update crates/noirc_frontend/src/monomorphization/mod.rs

  Show description for 8a5825f
  

  vezenovm

  and

  jfecher

  authored
  8a5825f

• Update crates/noirc_frontend/src/monomorphization/mod.rs

  Show description for 618d376
  

  vezenovm

  and

  jfecher

  authored
  618d376

• Update crates/noirc_frontend/src/monomorphization/mod.rs

  Show description for a940145
  

  vezenovm

  and

  jfecher

  authored
  a940145

• Update crates/noirc_frontend/src/parser/parser.rs

  Show description for 34f1d58
  

  vezenovm

  and

  jfecher

  authored
  34f1d58

• keep the size of fmtrstr type as mandatory

  vezenovm

  committed
  4f9bac7

• print original fmt string in monomorphization printer

  vezenovm

  committed
  c2e6ef7

• print literal update for fmtstr

  vezenovm

  committed
  5819d10

• add parens to f-string literal printer

  vezenovm

  committed
  9c95414