Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Drop support for the legacy SSA #2049

Merged
merged 3 commits into from
Jul 26, 2023
Merged

feat!: Drop support for the legacy SSA #2049

merged 3 commits into from
Jul 26, 2023

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

This PR nukes the legacy SSA codebase so we only have the new ssa_refactor codebase. I've left it in the ssa_refactor directory to reduce the diff in this PR although this can be addressed in a followup PR.

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench requested review from jfecher and kevaundray July 26, 2023 12:06
@TomAFrench
Copy link
Member Author

This is necessary for stepwise ACVM / ACVM 0.21.0 as we have removed the Block, RAM and ROM opcodes. We would then need to either update the legacy SSA to not use these or remove it entirely.

kevaundray
kevaundray previously approved these changes Jul 26, 2023
Copy link
Contributor

@kevaundray kevaundray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For fully resolving #1850 -- Will leave that to @vezenovm and @jfecher

@kevaundray kevaundray enabled auto-merge July 26, 2023 12:15
@kevaundray kevaundray added this pull request to the merge queue Jul 26, 2023
@vezenovm
Copy link
Contributor

This looks good to me for a first removal. We can clean up remaining issues to fully resolve #1850 in later PRs.

Merged via the queue into master with commit 3f33e44 Jul 26, 2023
@kevaundray kevaundray deleted the remove-legacy-ssa branch July 26, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants