Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Optimize x < 0 for unsigned x to false #2206

Merged
merged 2 commits into from
Aug 8, 2023
Merged

feat: Optimize x < 0 for unsigned x to false #2206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bae2e53
feat: Optimize `x < 0` for unsigned `x` to false
TomAFrench Aug 8, 2023
e667b8f
chore: add `Type::is_unsigned(&self)` method
TomAFrench Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions crates/noirc_evaluator/src/ssa/ir/instruction.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,6 +593,11 @@ impl Binary {
let zero = dfg.make_constant(FieldElement::zero(), Type::bool());
return SimplifyResult::SimplifiedTo(zero);
}
if operand_type.is_unsigned() && rhs_is_zero {
// Unsigned values cannot be less than zero.
let zero = dfg.make_constant(FieldElement::zero(), Type::bool());
return SimplifyResult::SimplifiedTo(zero);
}
}
BinaryOp::And => {
if lhs_is_zero || rhs_is_zero {
Expand Down
5 changes: 5 additions & 0 deletions crates/noirc_evaluator/src/ssa/ir/types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,11 @@ pub(crate) enum Type {
}

impl Type {
/// Returns whether the `Type` represents an unsigned numeric type.
pub(crate) fn is_unsigned(&self) -> bool {
matches!(self, Type::Numeric(NumericType::Unsigned { .. }))
}

/// Create a new signed integer type with the given amount of bits.
pub(crate) fn signed(bit_size: u32) -> Type {
Type::Numeric(NumericType::Signed { bit_size })
Expand Down