Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Automatically update acir artifacts #2454

Merged
merged 7 commits into from
Sep 21, 2023
Merged

chore: Automatically update acir artifacts #2454

merged 7 commits into from
Sep 21, 2023

Conversation

kevaundray
Copy link
Contributor

Description

This is not really tenable at the moment while we are still installing barretenberg.

Problem*

resolves #2453

Resolves

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray kevaundray marked this pull request as draft August 27, 2023 20:43
@kevaundray
Copy link
Contributor Author

This will fail since we are not installing barretenberg in the action/using nix

@kevaundray kevaundray marked this pull request as ready for review September 16, 2023 23:25
@kevaundray
Copy link
Contributor Author

We are no longer installing barretenberg so this is now tenable

jfecher
jfecher reviewed Sep 18, 2023
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'll defer to @TomAFrench's review

TomAFrench
TomAFrench previously approved these changes Sep 21, 2023
View reviewed changes
auto-merge was automatically disabled September 21, 2023 18:46

Merge queue setting changed

@kevaundray kevaundray merged commit f649871 into master Sep 21, 2023
@kevaundray kevaundray deleted the kw/auto-pr-rebuild-script branch September 21, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfecher jfecher jfecher left review comments

@TomAFrench TomAFrench TomAFrench approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create github action that automatically updates the acir artifacts
3 participants
@kevaundray @jfecher @TomAFrench