feat: Traits methods - default and override#2574

Closed

yordanmadzhunkov wants to merge 32 commits intonoir-lang:masterfrom metacraft-labs:sofia/traits

+586-239

Commits on Sep 6, 2023

Fix tests by removing trait implemetation checks from def_collector
ymadzhunkov
committed
fix(tests): simplify the trait-related compile_failure tests

nickysn
authored and
ymadzhunkov
committed
chore(tests): move tests that fail for a known reason to a subdirectory, where they're not executed

nickysn
authored and
ymadzhunkov
committed
test(traits): added more tests in KNOWN_FAILURES for the detection of duplicate impl of traits

nickysn
authored and
ymadzhunkov
committed
These 2 test should not compile!
ymadzhunkov
committed
Move tests to KNOWN FAILURES
ymadzhunkov
committed
Setup work for checks on Types

alexvitkov
authored and
ymadzhunkov
committed
remove debug printf

alexvitkov
authored and
ymadzhunkov
committed
Enable tests that implemetns trait twice
ymadzhunkov
committed
Try to build it
ymadzhunkov
committed
Fix error reporting when in case of duplicate trait implementation
ymadzhunkov
committed
Enable dup_trait_implementation_3
ymadzhunkov
committed
Code review comments
ymadzhunkov
committed
Fix build and tests
ymadzhunkov
committed
fix: public

alexvitkov
authored and
ymadzhunkov
committed
Enabling back tests that failed
ymadzhunkov
committed
Obtain function name from resolver
ymadzhunkov
committed
typevar for Trait::Self

alexvitkov
authored and
ymadzhunkov
committed
break up Trait::items into 3 arrays

alexvitkov
authored and
ymadzhunkov
committed
use unify instead of == to compare types

alexvitkov
authored and
ymadzhunkov
committed
remove clone

alexvitkov
authored and
ymadzhunkov
committed
test: add test

alexvitkov
authored and
ymadzhunkov
committed
New error when trait is implemented for non-struct

yordanmadzhunkov
authored and
ymadzhunkov
committed
add check for trait method argc

alexvitkov
authored and
ymadzhunkov
committed
consistent capitalization

alexvitkov
authored and
ymadzhunkov
committed
better error struct field names

alexvitkov
authored and
ymadzhunkov
committed
emit MethodNotInTrait when needed

alexvitkov
authored and
ymadzhunkov
committed
remove outdated todos

alexvitkov
authored and
ymadzhunkov
committed
Fix clippy
ymadzhunkov
committed
Rename test impl_trait_for_non_struct -> impl_trait_for_non_type
ymadzhunkov
committed
Fix cargo fmt
ymadzhunkov
committed
These tests are expected to execute successfully
ymadzhunkov
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Traits methods - default and override#2574

Commits on Sep 6, 2023

Fix tests by removing trait implemetation checks from def_collector

fix(tests): simplify the trait-related compile_failure tests

chore(tests): move tests that fail for a known reason to a subdirectory, where they're not executed

test(traits): added more tests in KNOWN_FAILURES for the detection of duplicate impl of traits

These 2 test should not compile!

Move tests to KNOWN FAILURES

Setup work for checks on Types

remove debug printf

Enable tests that implemetns trait twice

Try to build it

Fix error reporting when in case of duplicate trait implementation

Enable dup_trait_implementation_3

Code review comments

Fix build and tests

fix: public

Enabling back tests that failed

Obtain function name from resolver

typevar for Trait::Self

break up Trait::items into 3 arrays

use unify instead of == to compare types

remove clone

test: add test

New error when trait is implemented for non-struct

add check for trait method argc

consistent capitalization

better error struct field names

emit MethodNotInTrait when needed

remove outdated todos

Fix clippy

Rename test impl_trait_for_non_struct -> impl_trait_for_non_type

Fix cargo fmt

These tests are expected to execute successfully