Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor problems with aztec publishing #3095

Merged
merged 12 commits into from
Oct 12, 2023
Merged

fix: minor problems with aztec publishing #3095

Changes from 4 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d6954db
chore: fix newline character
kobyhallx Oct 11, 2023
3084620
chore: make master default
kobyhallx Oct 11, 2023
bd5867c
fix: newline in earlier step
kobyhallx Oct 11, 2023
de37e7f
chore: ensure latest version is proper semver
kobyhallx Oct 11, 2023
54c9f8f
chore: build wasm's separatelly
kobyhallx Oct 11, 2023
1378118
chore: include parameter in nightly version
kobyhallx Oct 11, 2023
1053be9
chore: ensure same source is built
kobyhallx Oct 11, 2023
e88d02c
chore: tag all packages with npm-tag input
kobyhallx Oct 11, 2023
337b1c8
chore: rework scripts
kobyhallx Oct 11, 2023
c04fcb2
chore: use upload and download pattern
kobyhallx Oct 12, 2023
6a78e3b
chore: whitespace change
TomAFrench Oct 12, 2023
24db63b
Merge branch 'master' into kh-fix-newline
TomAFrench Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions .github/workflows/publish-es-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ on:
noir-ref:
description: The noir reference to checkout
required: false
default: 'master'
npm-tag:
description: Repository Tag to publish under
required: false
Expand All @@ -20,7 +21,7 @@ jobs:
- name: Checkout sources
uses: actions/checkout@v4
with:
ref: ${{ inputs.noir-ref || 'master' }}
ref: ${{ inputs.noir-ref }}

- name: Setup Nix
uses: ./.github/actions/nix
Expand All @@ -32,7 +33,7 @@ jobs:
- name: Enable aztec features
if: ${{ inputs.npm-tag == 'aztec' }}
run: |
echo "\ndefault = [\"aztec\"]" >> compiler/noirc_frontend/Cargo.toml
echo $'\n'"default = [\"aztec\"]"$'\n' >> compiler/noirc_frontend/Cargo.toml

- name: Build wasm package
run: |
Expand All @@ -44,7 +45,7 @@ jobs:
- name: Checkout sources
uses: actions/checkout@v4
with:
ref: ${{ inputs.noir-ref || 'master' }}
ref: ${{ inputs.noir-ref }}

- name: Setup Nix
uses: ./.github/actions/nix
Expand All @@ -63,7 +64,7 @@ jobs:
- name: Checkout sources
uses: actions/checkout@v4
with:
ref: ${{ inputs.noir-ref || 'master' }}
ref: ${{ inputs.noir-ref }}

- name: Setup Nix
uses: ./.github/actions/nix
Expand All @@ -83,7 +84,7 @@ jobs:
- name: Checkout sources
uses: actions/checkout@v4
with:
ref: ${{ inputs.noir-ref || 'master' }}
ref: ${{ inputs.noir-ref }}

- name: Setup Nix
uses: ./.github/actions/nix
Expand All @@ -98,7 +99,7 @@ jobs:
- name: Enable aztec features
if: ${{ inputs.npm-tag == 'aztec' }}
run: |
echo "\ndefault = [\"aztec\"]" >> compiler/noirc_frontend/Cargo.toml
echo $'\n'"default = [\"aztec\"]"$'\n' >> compiler/noirc_frontend/Cargo.toml

- name: Build ES Packages
run: yarn prepare:publish
Expand All @@ -109,6 +110,7 @@ jobs:
yarn nightly:version

- name: Update Version as specific tag
if: ${{ inputs.npm-tag != 'latest' }}
run: |
jq '.version = .version + "-${{ inputs.npm-tag }}"' package.json > package-tmp.json && mv package-tmp.json package.json

Expand Down