Adds wasm methods for serialising and deserialising an acir structure #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasm-pack build --target nodejs
guipublic
reviewed
Sep 2, 2022
| pub fn acir_from_bytes(bytes: Vec<u8>) -> JsValue { | ||
| console_error_panic_hook::set_once(); | ||
| let circuit = Circuit::from_bytes(&bytes); | ||
| JsValue::from_serde(&circuit).unwrap() |
There was a problem hiding this comment.
It seems some people suggest not to use JsValue::from_serde anymore?
rustwasm/wasm-bindgen#3031
guipublic
approved these changes
Sep 2, 2022
jfecher
approved these changes
Sep 2, 2022
guipublic
added a commit
that referenced
this pull request
Sep 9, 2022
* Serialize ACIR circuits into bytes Using messagepack format + compression * Add a 'compile' command in Nargo to generate circuit and witness * Adds wasm methods for serialising and deserialising an acir structure (#331) * add serialisation methods for acir * update generated wasm: wasm-pack build --target nodejs * fix clippy issues Co-authored-by: kevaundray <kevtheappdev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.