Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test ACVM BigInt #5559

Merged
merged 39 commits into from
Aug 26, 2024
Merged
Show file tree
Hide file tree
Changes from 35 commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
9028cb7
chore: test bigint blackbox functions: add too-large bigint noir test…
michaeljklein Jul 18, 2024
6084ff7
Merge branch 'master' into michaeljklein/test-acvm-bigint
michaeljklein Jul 18, 2024
0a7d1d0
fix usage of function to generate a bigint == 1, fix cargo file from …
michaeljklein Jul 18, 2024
f3a2964
Merge branch 'master' into michaeljklein/test-acvm-bigint
michaeljklein Jul 22, 2024
491dd2c
add issue references, fix outdated comment
michaeljklein Jul 22, 2024
67f4023
update panic messages and replace "any::<T>()" with ": T"
michaeljklein Jul 22, 2024
fba26f6
Merge branch 'master' into michaeljklein/test-acvm-bigint
michaeljklein Jul 23, 2024
c14be47
clippy
michaeljklein Jul 23, 2024
ce0e1b6
enable overflow checks in release mode
michaeljklein Jul 23, 2024
77e91c8
Merge branch 'master' into michaeljklein/test-acvm-bigint
michaeljklein Jul 23, 2024
672f7fd
Merge branch 'master' into michaeljklein/test-acvm-bigint
michaeljklein Jul 24, 2024
3f6fa4b
remove redundant tests, move test for debugging 49 case to issue
michaeljklein Jul 25, 2024
d938be3
make type alias for (field element, use_constant), factor out convers…
michaeljklein Jul 25, 2024
392de57
Merge branch 'master' into michaeljklein/test-acvm-bigint
michaeljklein Jul 25, 2024
cdf7129
Merge branch 'master' into michaeljklein/test-acvm-bigint, patch bigi…
michaeljklein Jul 31, 2024
d475ce2
update other bigint generation functions and TODO's
michaeljklein Jul 31, 2024
a89351d
Merge branch 'master' into michaeljklein/test-acvm-bigint
michaeljklein Jul 31, 2024
b5ae2f7
Merge branch 'master' into michaeljklein/test-acvm-bigint
michaeljklein Aug 2, 2024
2c4c5ad
Merge branch 'master' into michaeljklein/test-acvm-bigint
michaeljklein Aug 5, 2024
6426741
Merge branch 'master' into michaeljklein/test-acvm-bigint
michaeljklein Aug 5, 2024
91778b3
Merge branch 'master' into michaeljklein/test-acvm-bigint
michaeljklein Aug 6, 2024
9a266c6
Merge branch 'master' into michaeljklein/test-acvm-bigint
michaeljklein Aug 9, 2024
7f6907e
responding to review comments: renaming vars and clarifying comments
michaeljklein Aug 9, 2024
f8c7598
use tuples instead of .0/.1 for bigint pair/triple functions
michaeljklein Aug 9, 2024
9464391
move conversion from vec of field to vec of ConstantOrWitness into he…
michaeljklein Aug 9, 2024
e328d83
cargo fmt
michaeljklein Aug 9, 2024
61088f5
Merge branch 'master' into michaeljklein/test-acvm-bigint
michaeljklein Aug 20, 2024
ae8a582
only enable overflow checks for new mode and tests, add note to BigIn…
michaeljklein Aug 20, 2024
98aee28
Merge branch 'master' into michaeljklein/test-acvm-bigint
michaeljklein Aug 21, 2024
60abcc6
cspell 'bignum'
michaeljklein Aug 21, 2024
9c75df6
Merge branch 'master' into michaeljklein/test-acvm-bigint
michaeljklein Aug 22, 2024
ad6145f
narrow down source of CI/local difference in bigint_from_to_le_bytes_…
michaeljklein Aug 22, 2024
72c90bd
Merge branch 'master' into michaeljklein/test-acvm-bigint
michaeljklein Aug 22, 2024
31ccacd
Merge branch 'master' into michaeljklein/test-acvm-bigint
michaeljklein Aug 23, 2024
c6aa660
Merge branch 'master' into michaeljklein/test-acvm-bigint
michaeljklein Aug 26, 2024
a7aaafc
patch test
michaeljklein Aug 26, 2024
06dc249
Merge remote-tracking branch 'refs/remotes/origin/michaeljklein/test-…
michaeljklein Aug 26, 2024
6861334
remove leftover debugging test
michaeljklein Aug 26, 2024
cdad432
Merge branch 'master' into michaeljklein/test-acvm-bigint
michaeljklein Aug 26, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,14 @@ rust-embed = "6.6.0"
# See https://ritik-mishra.medium.com/resolving-the-wasm-pack-error-locals-exceed-maximum-ec3a9d96685b
opt-level = 1

# release mode with extra checks, e.g. overflow checks
[profile.release-pedantic]
inherits = "release"
overflow-checks = true

[profile.test]
inherits = "dev"
overflow-checks = true

[profile.size]
inherits = "release"
Expand Down
2 changes: 0 additions & 2 deletions acvm-repo/acvm/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ repository.workspace = true
[lints]
workspace = true

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
num-bigint.workspace = true
thiserror.workspace = true
Expand Down
Loading
Loading