fix: distinguish TypePath with and without turbofish #6404

asterite · 2024-10-30T14:00:35Z

Description

Problem

Resolves #6188

Summary

We couldn't distinguish between Field::foo and Field::<>::foo, assuming it was always Field::<>::foo, trying to resolve the generics and filling missing ones with Type::Error, eventually leading to a compiler error.

Additional Context

While working on this I noticed that Type::kind might be returning the incorrect Kind for some types:

noir/compiler/noirc_frontend/src/hir_def/types.rs

Line 1379 in 4e44e1f

| Type::Error => Kind::Normal,

I talked about this with Michael, I might send a follow-up PR if I can find some code that doesn't work if we don't change that.

Documentation

Check one:

No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

jfecher

LGTM

compiler/noirc_frontend/src/parser/parser/expression.rs

…ng/noir#6396) feat: improve malformed test attribute error (noir-lang/noir#6414) fix: aliases in path (noir-lang/noir#6399) feat(profiler): Add Brillig procedure info to debug artifact for more informative profiling (noir-lang/noir#6385) chore(lsp): Remove profile code lens (noir-lang/noir#6411) chore(nargo): Remove old profile as part of info cmd (noir-lang/noir#6406) fix: distinguish TypePath with and without turbofish (noir-lang/noir#6404) fix: numeric generic doesn't have a default type (noir-lang/noir#6405) feat: Sync from aztec-packages (noir-lang/noir#6403) chore: add regression tests for #4372 (noir-lang/noir#6401) chore: add regression tests for #6314 (noir-lang/noir#6381)

…oir-lang/noir#6416) chore: create a regression test for #6420 (noir-lang/noir#6421) chore: Release Noir(0.37.0) (noir-lang/noir#6321) chore: update variable names in stdlib tests to be more correct (noir-lang/noir#6419) feat!: remove mimc from stdlib (noir-lang/noir#6402) chore: Replace dead link with updated route in README (noir-lang/noir#6392) feat(ci): Add report of Brillig opcodes executed (noir-lang/noir#6396) feat: improve malformed test attribute error (noir-lang/noir#6414) fix: aliases in path (noir-lang/noir#6399) feat(profiler): Add Brillig procedure info to debug artifact for more informative profiling (noir-lang/noir#6385) chore(lsp): Remove profile code lens (noir-lang/noir#6411) chore(nargo): Remove old profile as part of info cmd (noir-lang/noir#6406) fix: distinguish TypePath with and without turbofish (noir-lang/noir#6404) fix: numeric generic doesn't have a default type (noir-lang/noir#6405) feat: Sync from aztec-packages (noir-lang/noir#6403) chore: add regression tests for #4372 (noir-lang/noir#6401) chore: add regression tests for #6314 (noir-lang/noir#6381)

…ir#6416) chore: create a regression test for #6420 (noir-lang/noir#6421) chore: Release Noir(0.37.0) (noir-lang/noir#6321) chore: update variable names in stdlib tests to be more correct (noir-lang/noir#6419) feat!: remove mimc from stdlib (noir-lang/noir#6402) chore: Replace dead link with updated route in README (noir-lang/noir#6392) feat(ci): Add report of Brillig opcodes executed (noir-lang/noir#6396) feat: improve malformed test attribute error (noir-lang/noir#6414) fix: aliases in path (noir-lang/noir#6399) feat(profiler): Add Brillig procedure info to debug artifact for more informative profiling (noir-lang/noir#6385) chore(lsp): Remove profile code lens (noir-lang/noir#6411) chore(nargo): Remove old profile as part of info cmd (noir-lang/noir#6406) fix: distinguish TypePath with and without turbofish (noir-lang/noir#6404) fix: numeric generic doesn't have a default type (noir-lang/noir#6405) feat: Sync from aztec-packages (noir-lang/noir#6403) chore: add regression tests for #4372 (noir-lang/noir#6401) chore: add regression tests for #6314 (noir-lang/noir#6381)

…oir#6415) fix: fix Alias and Error kinds (noir-lang/noir#6426) fix: type-check turbofish in trait before function call (noir-lang/noir#6416) chore: create a regression test for #6420 (noir-lang/noir#6421) chore: Release Noir(0.37.0) (noir-lang/noir#6321) chore: update variable names in stdlib tests to be more correct (noir-lang/noir#6419) feat!: remove mimc from stdlib (noir-lang/noir#6402) chore: Replace dead link with updated route in README (noir-lang/noir#6392) feat(ci): Add report of Brillig opcodes executed (noir-lang/noir#6396) feat: improve malformed test attribute error (noir-lang/noir#6414) fix: aliases in path (noir-lang/noir#6399) feat(profiler): Add Brillig procedure info to debug artifact for more informative profiling (noir-lang/noir#6385) chore(lsp): Remove profile code lens (noir-lang/noir#6411) chore(nargo): Remove old profile as part of info cmd (noir-lang/noir#6406) fix: distinguish TypePath with and without turbofish (noir-lang/noir#6404) fix: numeric generic doesn't have a default type (noir-lang/noir#6405) feat: Sync from aztec-packages (noir-lang/noir#6403) chore: add regression tests for #4372 (noir-lang/noir#6401) chore: add regression tests for #6314 (noir-lang/noir#6381)

fix: fix Alias and Error kinds (noir-lang/noir#6426) fix: type-check turbofish in trait before function call (noir-lang/noir#6416) chore: create a regression test for #6420 (noir-lang/noir#6421) chore: Release Noir(0.37.0) (noir-lang/noir#6321) chore: update variable names in stdlib tests to be more correct (noir-lang/noir#6419) feat!: remove mimc from stdlib (noir-lang/noir#6402) chore: Replace dead link with updated route in README (noir-lang/noir#6392) feat(ci): Add report of Brillig opcodes executed (noir-lang/noir#6396) feat: improve malformed test attribute error (noir-lang/noir#6414) fix: aliases in path (noir-lang/noir#6399) feat(profiler): Add Brillig procedure info to debug artifact for more informative profiling (noir-lang/noir#6385) chore(lsp): Remove profile code lens (noir-lang/noir#6411) chore(nargo): Remove old profile as part of info cmd (noir-lang/noir#6406) fix: distinguish TypePath with and without turbofish (noir-lang/noir#6404) fix: numeric generic doesn't have a default type (noir-lang/noir#6405) feat: Sync from aztec-packages (noir-lang/noir#6403) chore: add regression tests for #4372 (noir-lang/noir#6401) chore: add regression tests for #6314 (noir-lang/noir#6381)

…ang/noir#6413) feat: ensure that generated ACIR is solvable (noir-lang/noir#6415) fix: fix Alias and Error kinds (noir-lang/noir#6426) fix: type-check turbofish in trait before function call (noir-lang/noir#6416) chore: create a regression test for #6420 (noir-lang/noir#6421) chore: Release Noir(0.37.0) (noir-lang/noir#6321) chore: update variable names in stdlib tests to be more correct (noir-lang/noir#6419) feat!: remove mimc from stdlib (noir-lang/noir#6402) chore: Replace dead link with updated route in README (noir-lang/noir#6392) feat(ci): Add report of Brillig opcodes executed (noir-lang/noir#6396) feat: improve malformed test attribute error (noir-lang/noir#6414) fix: aliases in path (noir-lang/noir#6399) feat(profiler): Add Brillig procedure info to debug artifact for more informative profiling (noir-lang/noir#6385) chore(lsp): Remove profile code lens (noir-lang/noir#6411) chore(nargo): Remove old profile as part of info cmd (noir-lang/noir#6406) fix: distinguish TypePath with and without turbofish (noir-lang/noir#6404) fix: numeric generic doesn't have a default type (noir-lang/noir#6405) feat: Sync from aztec-packages (noir-lang/noir#6403) chore: add regression tests for #4372 (noir-lang/noir#6401) chore: add regression tests for #6314 (noir-lang/noir#6381)

feat: ensure that generated ACIR is solvable (noir-lang/noir#6415) fix: fix Alias and Error kinds (noir-lang/noir#6426) fix: type-check turbofish in trait before function call (noir-lang/noir#6416) chore: create a regression test for #6420 (noir-lang/noir#6421) chore: Release Noir(0.37.0) (noir-lang/noir#6321) chore: update variable names in stdlib tests to be more correct (noir-lang/noir#6419) feat!: remove mimc from stdlib (noir-lang/noir#6402) chore: Replace dead link with updated route in README (noir-lang/noir#6392) feat(ci): Add report of Brillig opcodes executed (noir-lang/noir#6396) feat: improve malformed test attribute error (noir-lang/noir#6414) fix: aliases in path (noir-lang/noir#6399) feat(profiler): Add Brillig procedure info to debug artifact for more informative profiling (noir-lang/noir#6385) chore(lsp): Remove profile code lens (noir-lang/noir#6411) chore(nargo): Remove old profile as part of info cmd (noir-lang/noir#6406) fix: distinguish TypePath with and without turbofish (noir-lang/noir#6404) fix: numeric generic doesn't have a default type (noir-lang/noir#6405) feat: Sync from aztec-packages (noir-lang/noir#6403) chore: add regression tests for #4372 (noir-lang/noir#6401) chore: add regression tests for #6314 (noir-lang/noir#6381)

…ang/noir#6413) feat: ensure that generated ACIR is solvable (noir-lang/noir#6415) fix: fix Alias and Error kinds (noir-lang/noir#6426) fix: type-check turbofish in trait before function call (noir-lang/noir#6416) chore: create a regression test for #6420 (noir-lang/noir#6421) chore: Release Noir(0.37.0) (noir-lang/noir#6321) chore: update variable names in stdlib tests to be more correct (noir-lang/noir#6419) feat!: remove mimc from stdlib (noir-lang/noir#6402) chore: Replace dead link with updated route in README (noir-lang/noir#6392) feat(ci): Add report of Brillig opcodes executed (noir-lang/noir#6396) feat: improve malformed test attribute error (noir-lang/noir#6414) fix: aliases in path (noir-lang/noir#6399) feat(profiler): Add Brillig procedure info to debug artifact for more informative profiling (noir-lang/noir#6385) chore(lsp): Remove profile code lens (noir-lang/noir#6411) chore(nargo): Remove old profile as part of info cmd (noir-lang/noir#6406) fix: distinguish TypePath with and without turbofish (noir-lang/noir#6404) fix: numeric generic doesn't have a default type (noir-lang/noir#6405) feat: Sync from aztec-packages (noir-lang/noir#6403) chore: add regression tests for #4372 (noir-lang/noir#6401) chore: add regression tests for #6314 (noir-lang/noir#6381)

feat: ensure that generated ACIR is solvable (noir-lang/noir#6415) fix: fix Alias and Error kinds (noir-lang/noir#6426) fix: type-check turbofish in trait before function call (noir-lang/noir#6416) chore: create a regression test for #6420 (noir-lang/noir#6421) chore: Release Noir(0.37.0) (noir-lang/noir#6321) chore: update variable names in stdlib tests to be more correct (noir-lang/noir#6419) feat!: remove mimc from stdlib (noir-lang/noir#6402) chore: Replace dead link with updated route in README (noir-lang/noir#6392) feat(ci): Add report of Brillig opcodes executed (noir-lang/noir#6396) feat: improve malformed test attribute error (noir-lang/noir#6414) fix: aliases in path (noir-lang/noir#6399) feat(profiler): Add Brillig procedure info to debug artifact for more informative profiling (noir-lang/noir#6385) chore(lsp): Remove profile code lens (noir-lang/noir#6411) chore(nargo): Remove old profile as part of info cmd (noir-lang/noir#6406) fix: distinguish TypePath with and without turbofish (noir-lang/noir#6404) fix: numeric generic doesn't have a default type (noir-lang/noir#6405) feat: Sync from aztec-packages (noir-lang/noir#6403) chore: add regression tests for #4372 (noir-lang/noir#6401) chore: add regression tests for #6314 (noir-lang/noir#6381)

…ang/noir#6413) feat: ensure that generated ACIR is solvable (noir-lang/noir#6415) fix: fix Alias and Error kinds (noir-lang/noir#6426) fix: type-check turbofish in trait before function call (noir-lang/noir#6416) chore: create a regression test for #6420 (noir-lang/noir#6421) chore: Release Noir(0.37.0) (noir-lang/noir#6321) chore: update variable names in stdlib tests to be more correct (noir-lang/noir#6419) feat!: remove mimc from stdlib (noir-lang/noir#6402) chore: Replace dead link with updated route in README (noir-lang/noir#6392) feat(ci): Add report of Brillig opcodes executed (noir-lang/noir#6396) feat: improve malformed test attribute error (noir-lang/noir#6414) fix: aliases in path (noir-lang/noir#6399) feat(profiler): Add Brillig procedure info to debug artifact for more informative profiling (noir-lang/noir#6385) chore(lsp): Remove profile code lens (noir-lang/noir#6411) chore(nargo): Remove old profile as part of info cmd (noir-lang/noir#6406) fix: distinguish TypePath with and without turbofish (noir-lang/noir#6404) fix: numeric generic doesn't have a default type (noir-lang/noir#6405) feat: Sync from aztec-packages (noir-lang/noir#6403) chore: add regression tests for #4372 (noir-lang/noir#6401) chore: add regression tests for #6314 (noir-lang/noir#6381)

feat: ensure that generated ACIR is solvable (noir-lang/noir#6415) fix: fix Alias and Error kinds (noir-lang/noir#6426) fix: type-check turbofish in trait before function call (noir-lang/noir#6416) chore: create a regression test for #6420 (noir-lang/noir#6421) chore: Release Noir(0.37.0) (noir-lang/noir#6321) chore: update variable names in stdlib tests to be more correct (noir-lang/noir#6419) feat!: remove mimc from stdlib (noir-lang/noir#6402) chore: Replace dead link with updated route in README (noir-lang/noir#6392) feat(ci): Add report of Brillig opcodes executed (noir-lang/noir#6396) feat: improve malformed test attribute error (noir-lang/noir#6414) fix: aliases in path (noir-lang/noir#6399) feat(profiler): Add Brillig procedure info to debug artifact for more informative profiling (noir-lang/noir#6385) chore(lsp): Remove profile code lens (noir-lang/noir#6411) chore(nargo): Remove old profile as part of info cmd (noir-lang/noir#6406) fix: distinguish TypePath with and without turbofish (noir-lang/noir#6404) fix: numeric generic doesn't have a default type (noir-lang/noir#6405) feat: Sync from aztec-packages (noir-lang/noir#6403) chore: add regression tests for #4372 (noir-lang/noir#6401) chore: add regression tests for #6314 (noir-lang/noir#6381)

…ang/noir#6413) feat: ensure that generated ACIR is solvable (noir-lang/noir#6415) fix: fix Alias and Error kinds (noir-lang/noir#6426) fix: type-check turbofish in trait before function call (noir-lang/noir#6416) chore: create a regression test for #6420 (noir-lang/noir#6421) chore: Release Noir(0.37.0) (noir-lang/noir#6321) chore: update variable names in stdlib tests to be more correct (noir-lang/noir#6419) feat!: remove mimc from stdlib (noir-lang/noir#6402) chore: Replace dead link with updated route in README (noir-lang/noir#6392) feat(ci): Add report of Brillig opcodes executed (noir-lang/noir#6396) feat: improve malformed test attribute error (noir-lang/noir#6414) fix: aliases in path (noir-lang/noir#6399) feat(profiler): Add Brillig procedure info to debug artifact for more informative profiling (noir-lang/noir#6385) chore(lsp): Remove profile code lens (noir-lang/noir#6411) chore(nargo): Remove old profile as part of info cmd (noir-lang/noir#6406) fix: distinguish TypePath with and without turbofish (noir-lang/noir#6404) fix: numeric generic doesn't have a default type (noir-lang/noir#6405) feat: Sync from aztec-packages (noir-lang/noir#6403) chore: add regression tests for #4372 (noir-lang/noir#6401) chore: add regression tests for #6314 (noir-lang/noir#6381)

Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat: nargo command to generate shell completions (noir-lang/noir#6413) feat: ensure that generated ACIR is solvable (noir-lang/noir#6415) fix: fix Alias and Error kinds (noir-lang/noir#6426) fix: type-check turbofish in trait before function call (noir-lang/noir#6416) chore: create a regression test for #6420 (noir-lang/noir#6421) chore: Release Noir(0.37.0) (noir-lang/noir#6321) chore: update variable names in stdlib tests to be more correct (noir-lang/noir#6419) feat!: remove mimc from stdlib (noir-lang/noir#6402) chore: Replace dead link with updated route in README (noir-lang/noir#6392) feat(ci): Add report of Brillig opcodes executed (noir-lang/noir#6396) feat: improve malformed test attribute error (noir-lang/noir#6414) fix: aliases in path (noir-lang/noir#6399) feat(profiler): Add Brillig procedure info to debug artifact for more informative profiling (noir-lang/noir#6385) chore(lsp): Remove profile code lens (noir-lang/noir#6411) chore(nargo): Remove old profile as part of info cmd (noir-lang/noir#6406) fix: distinguish TypePath with and without turbofish (noir-lang/noir#6404) fix: numeric generic doesn't have a default type (noir-lang/noir#6405) feat: Sync from aztec-packages (noir-lang/noir#6403) chore: add regression tests for #4372 (noir-lang/noir#6401) chore: add regression tests for #6314 (noir-lang/noir#6381) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <tom@tomfren.ch> Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>

asterite added 2 commits October 30, 2024 10:57

fix: distinguish TypePath with and without turbofish

e3009e5

Use map, and don't default empty generics to None

42911a7

asterite requested a review from a team October 30, 2024 14:17

jfecher approved these changes Oct 30, 2024

View reviewed changes

compiler/noirc_frontend/src/parser/parser/expression.rs Outdated Show resolved Hide resolved

use bool::then

ab4c994

asterite enabled auto-merge October 30, 2024 14:58

asterite added this pull request to the merge queue Oct 30, 2024

Merged via the queue into master with commit 0e974c2 Oct 30, 2024
47 checks passed

asterite deleted the ab/type-path-no-turbofish branch October 30, 2024 15:23

noirwhal mentioned this pull request Oct 30, 2024

chore: Release Noir(0.37.0) #6321

Merged

AztecBot mentioned this pull request Oct 31, 2024

feat: Sync from noir AztecProtocol/aztec-packages#9617

Closed

AztecBot mentioned this pull request Nov 4, 2024

feat: Sync from noir AztecProtocol/aztec-packages#9711

Merged

AztecBot mentioned this pull request Nov 4, 2024

chore(master): Release 0.63.0 AztecProtocol/aztec-packages#9651

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: distinguish TypePath with and without turbofish #6404

fix: distinguish TypePath with and without turbofish #6404

asterite commented Oct 30, 2024

jfecher left a comment

fix: distinguish TypePath with and without turbofish #6404

fix: distinguish TypePath with and without turbofish #6404

Conversation

asterite commented Oct 30, 2024

Description

Problem

Summary

Additional Context

Documentation

PR Checklist

jfecher left a comment

Choose a reason for hiding this comment