-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(test): Enable the test fuzzer for Wasm #6835
Open
aakoshh
wants to merge
15
commits into
master
Choose a base branch
from
6738-fuzz-wasm
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peak Memory Sample
|
Compilation Sample
|
asterite
reviewed
Dec 17, 2024
This was referenced Dec 18, 2024
Merged
Execution Sample
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #6738
Summary*
proptest
to 1.6 to be able to useu128
andi128
strategies with WasmUIntStrategy
with max 64 bit size, still returningu128
IntStrategy
with max 64 bit size, still returningi128
FuzzedExecutor
for#[test]
s with inputs on Wasmunix
orwindows
).Additional Context
The ticket says:
I couldn't find where exactly this happened, it would be nice to include a link.
I started with using
u64
instead ofu128
, andi64
instead ofi128
; the latter covers half the range as if we usedu64
and mapped to negative or positive based on whether the randomstart
value we picked was negative or positive. I did it that way becauseproptest
enabledi128
andu128
for Wasm just last week, and I thought it would be easier to to go back to usingi128
when it's released. Then I noticed thatproptest
1.6 was actually just released yesterday, and it includes the above change, it just didn't have a tag in the repo 🎉On a different note this shifting makes it look like we don't even want negative values for signed numbers, so maybe it would be easier to just use the
UIntStrategy
withoutfixtures
and covert the returned value toi128
.Compilation
CI uses
wasm-pack
, but we can also compile it locally with:Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.