Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): fix script to generate public inputs for solidity verification #6853

Closed
wants to merge 1 commit into from

Conversation

saleel
Copy link
Contributor

@saleel saleel commented Dec 18, 2024

Description

Problem*

Resolves

Summary*

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 18, 2024
Copy link
Contributor

Changes to Brillig bytecode sizes

Generated at commit: 056f23397cdba71b3a936030b8b47224d4bbfb61, compared to commit: 73ccd45590222fc82642a6a9aa657c2915fc2c58

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
poseidonsponge_x5_254 +3 ❌ +0.07%
sha256_regression -3 ✅ -0.04%

Full diff report 👇
Program Brillig opcodes (+/-) %
poseidonsponge_x5_254 4,254 (+3) +0.07%
sha256_regression 6,917 (-3) -0.04%

Copy link
Contributor

Changes to number of Brillig opcodes executed

Generated at commit: 056f23397cdba71b3a936030b8b47224d4bbfb61, compared to commit: 73ccd45590222fc82642a6a9aa657c2915fc2c58

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
poseidonsponge_x5_254 +3 ❌ +0.00%

Full diff report 👇
Program Brillig opcodes (+/-) %
poseidonsponge_x5_254 183,753 (+3) +0.00%

Copy link
Contributor

Peak Memory Sample

Program Peak Memory
keccak256 78.15M
workspace 122.73M
regression_4709 423.26M
ram_blowup_regression 1.58G
private-kernel-tail 206.71M
private-kernel-reset 720.29M
private-kernel-inner 291.91M
parity-root 171.71M

Copy link
Contributor

Compilation Sample

Program Compilation Time %
sha256_regression 0m1.408s -4%
regression_4709 0m0.822s -3%
ram_blowup_regression 0m14.760s -2%
rollup-base-public 3m23.206s -4%
rollup-base-private 3m13.558s 5%
private-kernel-tail 0m1.144s -10%
private-kernel-reset 0m8.111s 3%
private-kernel-inner 0m2.494s 10%
parity-root 0m0.844s -26%
noir-contracts 2m51.473s -2%

Copy link
Contributor

Copy link
Contributor

FYI @noir-lang/developerrelations on Noir doc changes.

@saleel saleel marked this pull request as ready for review December 18, 2024 12:40
@saleel saleel requested a review from signorecello December 18, 2024 12:40
@saleel
Copy link
Contributor Author

saleel commented Dec 18, 2024

Not need after #6804

@saleel saleel closed this Dec 18, 2024
@saleel saleel deleted the saleel/fix-docs-solidity branch December 18, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant