Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(LSP): suggest trait methods from where clauses #6915

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

asterite
Copy link
Collaborator

Description

Problem

No issue, just something I noticed while working with traits.

Summary

Previously only into() was suggested here:

lsp-suggest-trait-methods

Additional Context

This currently doesn't work inside trait methods. While figuring out why I noticed we don't track the trait method location, so I added that. It still didn't work but then I remembered that we currently don't type-check trait methods at all... but I still left the code I changed before that so that when we implement type-checking trait methods it will start working.

Documentation

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

Peak Memory Sample

Program Peak Memory
keccak256 78.48M
workspace 123.79M
regression_4709 422.91M
ram_blowup_regression 1.58G
private-kernel-tail 201.61M
private-kernel-reset 716.87M
private-kernel-inner 291.68M
parity-root 171.93M

Copy link
Contributor

Execution Sample

Program Execution Time %
sha256_regression 0.636s 3%
regression_4709 0.394s 3%
ram_blowup_regression 4.523s 2%
rollup-base-public 21.542s 2%
rollup-base-private 19.540s 0%
private-kernel-tail 0.707s 0%
private-kernel-reset 1.490s 1%
private-kernel-inner 0.990s 0%
parity-root 0.535s 0%

Copy link
Contributor

Compilation Sample

Program Compilation Time %
sha256_regression 1.407s 6%
regression_4709 0.786s 1%
ram_blowup_regression 16.525s 8%
rollup-base-public 126.256s 12%
rollup-base-private 100.447s 2%
private-kernel-tail 1.121s 8%
private-kernel-reset 7.615s 4%
private-kernel-inner 2.275s 4%
parity-root 0.797s 1%
noir-contracts 89.772s 4%

@asterite asterite requested a review from a team December 23, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant