Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move nargo I/O into separate module #896

Merged
merged 3 commits into from
Feb 22, 2023
Merged

chore: move nargo I/O into separate module #896

merged 3 commits into from
Feb 22, 2023

Conversation

TomAFrench
Copy link
Member

Related issue(s)

Resolves #884

Description

Summary of changes

The majority of the changes are just moving functions which load/write to file into the new fs module. I've also removed the preprocessing logic from fetch_pk_and_vk so that it's pure I/O as it's the CLI's responsibility to perform preprocessing where necessary.

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.
  • This PR requires documentation updates when merged.

Additional context

@phated
Copy link
Contributor

phated commented Feb 22, 2023

Do we want to take this further and split into the nargo-core and nargo-cli crates like @kevaundray suggested? I could see nargo-core becoming the basis for wasm stuff instead of the special noir_wasm crate.

Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with splitting out nargo-cli into a separate crate if it means less code duplication for the wasm crate, but this should be in a separate PR.

@TomAFrench
Copy link
Member Author

TomAFrench commented Feb 22, 2023

I'm aiming to not change functionality as much as possible in this PR so that substantive changes can be reviewed separately from code reshuffling.

That said, I also think that we should wait until nargo sits in its own repository before we split it up based on how small the resulting crates would be.

@TomAFrench
Copy link
Member Author

Will merge after #892

@TomAFrench TomAFrench added this pull request to the merge queue Feb 22, 2023
Merged via the queue into master with commit 8cafa34 Feb 22, 2023
@TomAFrench TomAFrench deleted the cli-rework branch February 22, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate off IO from nargo command logic
3 participants