Implement Api/Namespace Loggers #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteadBytes
force-pushed
the
namespace-loggers
branch
from
5cee8a6 to
c3736a7
Compare
|
I think this looks like a very useful suggestion. Simple, easy to maintain, and does the job. |
|
Great, thanks @casparjespersen , I'll get those TODOs cleaned up and then mark the PR as ready for review 👍 |
SteadBytes
force-pushed
the
namespace-loggers
branch
from
4abac5b to
9cb2ad8
Compare
|
@casparjespersen This is ready to go now, I've requested review from fellow core team member @j5awry but a 👍 (or improvement suggestions) from yourself would be greatly appreciated 😄 |
|
Is there a way we can get this merge in a release? I'm really interested in using the Namespace logger. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements per Api/Namespace logging as discussed in #694