Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated import for werkzeug's cached_property #738

Merged
merged 1 commit into from
Oct 22, 2019

Conversation

jonblum
Copy link
Contributor

@jonblum jonblum commented Oct 17, 2019

Resolves DeprecationWarning: The import 'werkzeug.cached_property' is deprecated and will be removed in Werkzeug 1.0. Use 'from werkzeug.utils import cached_property' instead. raised by Werkzeug 0.19+.

cached_property has always resided in werkzeug.utils, so this is backwards-compatible.

@coveralls
Copy link

coveralls commented Oct 17, 2019

Coverage Status

Coverage increased (+0.08%) to 96.882% when pulling f48b1d2 on jonblum:master into 9b9ad42 on noirbizarre:master.

@andreykurilin
Copy link

looks good to me and should be compatible with minimum required versions of packages:

Flask >=0.8


Werkzeug>=0.6.1 https://github.com/pallets/flask/blob/0.8/setup.py#L93
werkzeug.utils.cached_propert exists at https://github.com/pallets/werkzeug/blob/0.6.1/werkzeug/utils.py#L30

@ziirish
Copy link
Collaborator

ziirish commented Oct 22, 2019

Thanks

@ziirish ziirish merged commit c92a126 into noirbizarre:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants