Invoke 'UpdateConfigNANDSavegame' command after writing EULAs #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After writing EULAs to the config info block, call the `CFG_UpdateConfigSavegame()` function (which was formerly named `CFG_UpdateConfigNANDSavegame()` in older versions of libctru). This is a code change, mimicking the behaviour of the EULASetter app that DSES is based on. This also tweaks some of the messages printed to the screen. Fixes an issue in which EULAs weren't guaranteed to persist after the system reboots or is powered off.
|
Thanks a ton for the PR! I'll merge and release it ASAP - code looks good! |
noirscape
added a commit
that referenced
this pull request
Oct 21, 2024
This release fixes #1 and fixes #2 (using PR #3). In short, DSES was not calling the CFG_UpdateConfigSavegame function when it was supposed to. Thanks to @DimitriPilot3 for fixing this bug!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code changes:
Explanation:
The original EULASetter source code refers to a libctru function named
CFG_UpdateConfigNANDSavegame, which has been renamed toCFG_UpdateConfigSavegamesince libctru 1.4.0 (or so). This function invokes a CFG service command of the same name. Without it, changes to the EULAs made in DSES are only made in memory and may be lost after the system reboots or is powered off.