Refactoring include paths on EO module #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ropinho
changed the title
|
I finally found time to review, fix introduced bugs, squash and merge. Thanks! |
jdreo
pushed a commit
to jdreo/paradiseo
that referenced
this pull request
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring refers to Issue #1
... But only for EO module.
All files that needed was modified to relative include paths in directory
eo.The files within a directory, such as ga/eoBit.h for example, modified from:
#include <eoVector.h>to#include "../eoVector.h".The files in same directory includes directly, files in different directory uses navigation through directories using
../and[dir-names]/.I tested the building process and the usage various times before push.
The absolute include problem apparently was solved.