Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): use ubuntu 22.04 for now #483

Merged
merged 1 commit into from
Dec 15, 2024
Merged

chore(ci): use ubuntu 22.04 for now #483

merged 1 commit into from
Dec 15, 2024

Conversation

nolanlawson
Copy link
Owner

The memory leak tests are now giving this error due to Puppeteer running in Ubuntu 24.04:

Error: Failed to launch the browser process!
[3197:3197:1214/235227.041856:FATAL:zygote_host_impl_linux.cc(128)] No usable sandbox! If you are running on Ubuntu 23.10+ or another Linux distro that has disabled unprivileged user namespaces with AppArmor, see https://chromium.googlesource.com/chromium/src/+/main/docs/security/apparmor-userns-restrictions.md. Otherwise see https://chromium.googlesource.com/chromium/src/+/main/docs/linux/suid_sandbox_development.md for more information on developing with the (older) SUID sandbox. If you want to live dangerously and need an immediate workaround, you can try using --no-sandbox.
[1214/235227.049018:ERROR:file_io_posix.cc(145)] open /sys/devices/system/cpu/cpu0/cpufreq/scaling_cur_freq: No such file or directory (2)
[1214/235227.049060:ERROR:file_io_posix.cc(145)] open /sys/devices/system/cpu/cpu0/cpufreq/scaling_max_freq: No such file or directory (2)

I can't be bothered to figure out which magic incantation I need to get this to work, so let's just switch to Ubuntu 22.04. Once 22.04 is EOL I'm sure there will be more Google hits for this problem.

Copy link

github-actions bot commented Dec 15, 2024

📊 Tachometer Benchmark Results

Summary

benchmark-total

  • emoji-picker-element-change-tab: unsure 🔍 -2% - +2% (-0.58ms - +0.70ms)
    this-change vs tip-of-tree
  • emoji-picker-element-database-interactions: unsure 🔍 -3% - +2% (-3.48ms - +2.20ms)
    this-change vs tip-of-tree
  • emoji-picker-element-first-load: unsure 🔍 -2% - +3% (-1.34ms - +1.86ms)
    this-change vs tip-of-tree
  • emoji-picker-element-many-custom-emoji: unsure 🔍 -7% - +4% (-9.41ms - +5.31ms)
    this-change vs tip-of-tree
  • emoji-picker-element-second-load: unsure 🔍 -1% - +7% (-0.26ms - +3.39ms)
    this-change vs tip-of-tree

Results

emoji-picker-element-change-tab
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
33.43ms - 34.38ms-unsure 🔍
-2% - +2%
-0.58ms - +0.70ms
tip-of-tree
tip-of-tree
33.42ms - 34.27msunsure 🔍
-2% - +2%
-0.70ms - +0.58ms
-
emoji-picker-element-database-interactions
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
111.56ms - 115.57ms-unsure 🔍
-3% - +2%
-3.48ms - +2.20ms
tip-of-tree
tip-of-tree
112.19ms - 116.22msunsure 🔍
-2% - +3%
-2.20ms - +3.48ms
-
emoji-picker-element-first-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
53.35ms - 55.82ms-unsure 🔍
-2% - +3%
-1.34ms - +1.86ms
tip-of-tree
tip-of-tree
53.31ms - 55.35msunsure 🔍
-3% - +2%
-1.86ms - +1.34ms
-
emoji-picker-element-many-custom-emoji
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
123.24ms - 133.17ms-unsure 🔍
-7% - +4%
-9.41ms - +5.31ms
tip-of-tree
tip-of-tree
124.82ms - 135.70msunsure 🔍
-4% - +7%
-5.31ms - +9.41ms
-
emoji-picker-element-second-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
47.33ms - 50.11ms-unsure 🔍
-1% - +7%
-0.26ms - +3.39ms
tip-of-tree
tip-of-tree
45.98ms - 48.34msunsure 🔍
-7% - +0%
-3.39ms - +0.26ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link

Size Change: 0 B

Total Size: 37.3 kB

ℹ️ View Unchanged
Filename Size
./bundle.js 37.3 kB

compressed-size-action

@nolanlawson nolanlawson merged commit f8eea73 into master Dec 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant