perf: reduce server-side memory usage of Pinafore (#973)

fixes #971
nolanlawson · Feb 13, 2019 · 91f954d · 91f954d
1 parent 3aee6fb
commit 91f954d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/Dockerfile b/Dockerfile
@@ -19,5 +19,7 @@ RUN yarn build
 # Expose port 4002
 EXPOSE 4002
 
-# Setting run-command
-CMD PORT=4002 yarn start
+# Setting run-command, using explicit `node` command
+# rather than `yarn` or `npm` to use less memory
+# https://github.com/nolanlawson/pinafore/issues/971
+CMD PORT=4002 node __sapper__/build
diff --git a/README.md b/README.md
@@ -58,7 +58,7 @@ To build Pinafore for production:
 
     yarn --pure-lockfile
     yarn build
-    PORT=4002 yarn start
+    PORT=4002 node __sapper__/build
 
 ### Docker
 

diff --git a/package.json b/package.json
@@ -8,12 +8,11 @@
     "dev": "run-s build-template-html build-third-party-assets serve-dev",
     "serve-dev": "run-p --race build-template-html-watch sapper-dev",
     "sapper-dev": "cross-env NODE_ENV=development PORT=4002 sapper dev",
-    "sapper-prod": "cross-env PORT=4002 node __sapper__/build",
     "before-build": "run-s build-template-html build-third-party-assets",
     "build": "cross-env NODE_ENV=production run-s build-steps",
     "build-steps": "run-s before-build sapper-build",
     "sapper-build": "sapper build",
-    "start": "cross-env NODE_ENV=production run-s sapper-prod",
+    "start": "PORT=4002 node __sapper__/build",
     "build-and-start": "run-s build start",
     "build-template-html": "node -r esm ./bin/build-template-html.js",
     "build-template-html-watch": "node -r esm ./bin/build-template-html.js --watch",