Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polls without an expiry date don't display results correctly #2112

Closed
codl opened this issue Feb 28, 2022 · 0 comments · Fixed by #2145
Closed

Polls without an expiry date don't display results correctly #2112

codl opened this issue Feb 28, 2022 · 0 comments · Fixed by #2145
Labels
bug Something isn't working compatibility Compat with Pleroma, glitch-soc, etc.

Comments

@codl
Copy link
Contributor

codl commented Feb 28, 2022

Apparently, misskey instances can make endless polls. Here's a post that has a poll with no expiry date: https://stop.voring.me/notes/8x6ayzwr99

JSON
{
	"id": "107860010951403597",
	"created_at": "2022-02-25T18:19:15.915Z",
	"in_reply_to_id": null,
	"in_reply_to_account_id": null,
	"sensitive": false,
	"spoiler_text": "",
	"visibility": "unlisted",
	"language": "en",
	"uri": "https://stop.voring.me/notes/8x6ayzwr99",
	"url": "https://stop.voring.me/notes/8x6ayzwr99",
	"replies_count": 2,
	"reblogs_count": 17,
	"favourites_count": 0,
	"favourited": false,
	"reblogged": false,
	"muted": false,
	"bookmarked": false,
	"content": "\\u003cp\\u003e\\u003cspan\\u003eDo you see the description on this image? Boost for sample size.ㅤ\\u003c/span\\u003e\\u003c/p\\u003e",
	"reblog": null,
	"account": {
		"id": "107845256164753342",
		"username": "forever",
		"acct": "forever@stop.voring.me",
		"display_name": "Föraafr :aroace_heart:🐈💙💛",
		"locked": true,
		"bot": true,
		"discoverable": true,
		"group": false,
		"created_at": "2022-02-23T00:00:00.000Z",
		"note": "\\u003cp\\u003e\\u003cspan\\u003e\\u003cbr\\u003e\\u003c/span\\u003e​:ace_sign:​\\u003cspan\\u003e \\u003c/span\\u003e​:nb:​\\u003cspan\\u003e\\u003cbr\\u003e\\u003cbr\\u003e\\u003cbr\\u003eSaluton. Mi estas Forever. \\u003c/span\\u003e​:blobcat_happy_paws:​\\u003cspan\\u003e\\u003cbr\\u003eshe/her they/them \\u003c/span\\u003e​:blobcat_headache:​\\u003cspan\\u003e\\u003cbr\\u003eI'm a minor and don't appreciate untagged NSFW. \\u003c/span\\u003e​:blobhaj_heart:​\\u003cspan\\u003e\\u003cbr\\u003ePlease look at my full bio here, especially before following: \\u003c/span\\u003e\\u003ca href=\"https://stop.voring.me/@forever/pages/bio\" rel=\"nofollow noopener noreferrer\" target=\"_blank\"\\u003ehttps://stop.voring.me/@forever/pages/bio\\u003c/a\\u003e\\u003cspan\\u003e \\u003c/span\\u003e​:blobhaj:​\\u003c/p\\u003e",
		"url": "https://stop.voring.me/@forever",
		"avatar": "https://media.chitter.xyz/cache/accounts/avatars/107/845/256/164/753/342/original/3b8435a8f063fba8.png",
		"avatar_static": "https://media.chitter.xyz/cache/accounts/avatars/107/845/256/164/753/342/original/3b8435a8f063fba8.png",
		"header": "https://media.chitter.xyz/cache/accounts/headers/107/845/256/164/753/342/original/66ca75d460d4351d.jpeg",
		"header_static": "https://media.chitter.xyz/cache/accounts/headers/107/845/256/164/753/342/original/66ca75d460d4351d.jpeg",
		"followers_count": 0,
		"following_count": 0,
		"statuses_count": 1133,
		"last_status_at": "2022-02-28",
		"emojis": [
			{
				"shortcode": "ace_sign",
				"url": "https://media.chitter.xyz/cache/custom_emojis/images/000/169/057/original/0a9b0c9dd4ee1a8d.png",
				"static_url": "https://media.chitter.xyz/cache/custom_emojis/images/000/169/057/static/0a9b0c9dd4ee1a8d.png",
				"visible_in_picker": true
			},
			{
				"shortcode": "nb",
				"url": "https://media.chitter.xyz/cache/custom_emojis/images/000/166/353/original/d4634acd35a4e712.png",
				"static_url": "https://media.chitter.xyz/cache/custom_emojis/images/000/166/353/static/d4634acd35a4e712.png",
				"visible_in_picker": true
			},
			{
				"shortcode": "blobcat_happy_paws",
				"url": "https://media.chitter.xyz/cache/custom_emojis/images/000/166/172/original/173638714466eee5.png",
				"static_url": "https://media.chitter.xyz/cache/custom_emojis/images/000/166/172/static/173638714466eee5.png",
				"visible_in_picker": true
			},
			{
				"shortcode": "blobcat_headache",
				"url": "https://media.chitter.xyz/cache/custom_emojis/images/000/169/058/original/1270710604d88071.png",
				"static_url": "https://media.chitter.xyz/cache/custom_emojis/images/000/169/058/static/1270710604d88071.png",
				"visible_in_picker": true
			},
			{
				"shortcode": "blobhaj_heart",
				"url": "https://media.chitter.xyz/cache/custom_emojis/images/000/168/226/original/0982f4807b80b57e.png",
				"static_url": "https://media.chitter.xyz/cache/custom_emojis/images/000/168/226/static/0982f4807b80b57e.png",
				"visible_in_picker": true
			},
			{
				"shortcode": "blobhaj",
				"url": "https://media.chitter.xyz/cache/custom_emojis/images/000/166/642/original/9bc8d3024ba2c60b.png",
				"static_url": "https://media.chitter.xyz/cache/custom_emojis/images/000/166/642/static/9bc8d3024ba2c60b.png",
				"visible_in_picker": true
			},
			{
				"shortcode": "aroace_heart",
				"url": "https://media.chitter.xyz/cache/custom_emojis/images/000/169/130/original/a1433a6b99873ac3.png",
				"static_url": "https://media.chitter.xyz/cache/custom_emojis/images/000/169/130/static/a1433a6b99873ac3.png",
				"visible_in_picker": true
			}
		],
		"fields": [
			{
				"name": "🌐✉️",
				"value": "\\u003ca href=\"https://foreverxml.codeberg.page/\" rel=\"nofollow noopener noreferrer\" target=\"_blank\"\\u003ehttps://foreverxml.codeberg.page/\\u003c/a\\u003e",
				"verified_at": null
			},
			{
				"name": "🍰",
				"value": "Oct 2007",
				"verified_at": null
			},
			{
				"name": "🔊",
				"value": "/føːˈʁʕɐvərʔ/",
				"verified_at": null
			}
		]
	},
	"media_attachments": [
		{
			"id": "107860014969669001",
			"type": "image",
			"url": "https://media.chitter.xyz/cache/media_attachments/files/107/860/014/969/669/001/original/c4cf3448a797eee1.jpeg",
			"preview_url": "https://media.chitter.xyz/cache/media_attachments/files/107/860/014/969/669/001/small/c4cf3448a797eee1.jpeg",
			"remote_url": "https://pool.jortage.com/voringme/misskey/webpublic-e7021992-4c9d-4912-b6cb-2a52df305981.jpg",
			"preview_remote_url": null,
			"text_url": null,
			"meta": {
				"original": {
					"width": 616,
					"height": 805,
					"size": "616x805",
					"aspect": 0.7652173913043478
				},
				"small": {
					"width": 350,
					"height": 457,
					"size": "350x457",
					"aspect": 0.7658643326039387
				}
			},
			"description": "A portrait of an unnamed girl. She's wearing a beanie. I drew this art.",
			"blurhash": "U5HC7h?ctRxv~DV[t8WCJ6ofR%j[%3RjNGof"
		}
	],
	"mentions": [],
	"tags": [],
	"emojis": [],
	"card": null,
	"poll": {
		"id": "65639",
		"expires_at": null,
		"expired": false,
		"multiple": false,
		"votes_count": 305,
		"voters_count": null,
		"voted": true,
		"own_votes": [
			0
		],
		"options": [
			{
				"title": "Yes",
				"votes_count": 277
			},
			{
				"title": "No",
				"votes_count": 28
			}
		],
		"emojis": []
	}
}

After voting, in pinafore, the poll results don't display:

This is how it shows up in the mastodon web interface:

@nolanlawson nolanlawson added bug Something isn't working compatibility Compat with Pleroma, glitch-soc, etc. labels Mar 1, 2022
nolanlawson added a commit that referenced this issue May 14, 2022
nolanlawson added a commit that referenced this issue May 14, 2022
* fix: invalid date strings

Fixes #2113

* fix: polls without expiry date

Fixes #2112
alice-werefox pushed a commit to alice-werefox/sema-werefox-cafe that referenced this issue Apr 3, 2023
* fix: invalid date strings

Fixes nolanlawson#2113

* fix: polls without expiry date

Fixes nolanlawson#2112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compatibility Compat with Pleroma, glitch-soc, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants