feat: Add "a" keyboard shortcut to bookmark a toot. #2268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thank you! I just added one small thing: help text (for when you press the |
|
Note that when the toast appears, the alert will get read already, so I'm not sure the live region announcement is necessary. |
|
Sorry I forgot to update the help text. That was a silly oversight. |
|
Ah yes, I forgot about the alert. The alert is actually preferable to the aria live region, so that sighted people get the feedback as well. |
|
In that case, are you happy for me to revert your live region change? The alert already gets displayed with my original code. |
|
No worries, I reverted it. Now it just has the shortcut help text I added. Thanks a lot! |
nolanlawson
approved these changes
Dec 2, 2022
alice-werefox
pushed a commit
to alice-werefox/sema-werefox-cafe
that referenced
this pull request
Apr 3, 2023
Fixes nolanlawson#2237. Co-authored-by: Nolan Lawson <nolan@nolanlawson.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2237.