Improve navigation readability #2274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase the background contrast for the selected page. Increase the prominance of the indictor bar so we dont need to rely on the background to have a strong contrast difference.
NickColley
added this to the Meet Web Content Accessibility Guidelines 2.1 level AA milestone
|
Look great to me! Thanks a bunch. 🙂 |
nolanlawson
approved these changes
Dec 2, 2022
alice-werefox
pushed a commit
to alice-werefox/sema-werefox-cafe
that referenced
this pull request
Apr 3, 2023
Increase the background contrast for the selected page. Increase the prominance of the indictor bar so we dont need to rely on the background to have a strong contrast difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the background of selected navigation items darker so it is easier to read with white text (this meets WCAG contrast requirements).
Make the indicator bar more prominent to make it clearer which item is selected now that the background is done less to indicate this.
Screenshots
Dark mode
Page selected
Before
After
Page hovered
Before
After
Light
Page selected
Before
After
Page hovered
Before
After
Mobile
Before
After