Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix port not defaulting to 4002, add server.js #976

Merged
merged 1 commit into from
Feb 13, 2019
Merged

fix: fix port not defaulting to 4002, add server.js #976

merged 1 commit into from
Feb 13, 2019

Conversation

nolanlawson
Copy link
Owner

Fixes #972 as well as a few other things:

  • perf: reduce server-side memory usage of Pinafore #973 exposed node __sapper__/build to self-hosters, which is ugly. This adds node server.js which is our wrapper to handle the port, and is also a lot cleaner
  • those running Pinafore in production on Windows (if they exist) are unbroken by removing the PORT=4002 from the npm script

@nolanlawson nolanlawson merged commit 2adf8a7 into master Feb 13, 2019
nolanlawson added a commit that referenced this pull request Feb 13, 2019
@nolanlawson
chore: tell now about server.js
b00b0d7 
fixes a deploy bug introduced in #976
@nolanlawson nolanlawson mentioned this pull request Feb 13, 2019
Merged
nolanlawson added a commit that referenced this pull request Feb 13, 2019
@nolanlawson
chore: tell now about server.js (#977)
2904019 
fixes a deploy bug introduced in #976
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nolanlawson