chore: upgrade to zeit 2 #998
Conversation
|
Also once sveltejs/sapper#566 is merged into Sapper, we can potentially just use |
|
Just occurred to me that we will lose the link rel=preload in the header due to this PR, but I think it's worth it to get the CDN working and switch to a faster static model. Even without the CDN, this seems faster since it doesn't have to go through a Node server. |
As of #998 we can no longer rely on JS files containing , let alone . This was a nice idea, but it's just not maintainable anymore nor does it provide a huge benefit.
As of #998 we can no longer rely on JS files containing , let alone . This was a nice idea, but it's just not maintainable anymore nor does it provide a huge benefit.
keep an eye on this issue 😀 sveltejs/sapper#402 |
|
oh man, I just saw sveltejs/sapper#568 🤦♂️ |
More work on fixing #985.
I'm not a huge fan of this implementation, because we now basically have two different "production" implemenations - one using
node server.js(using Express + Sapper middleware), and another using Sapper export plus a static fileserver in Now.But it does work, and the difference between the two is minimal. The only thing I had to do slightly differently was handling dynamic URLs like
/accounts/<accountId>- instead of letting Sapper middleware handle it, I just returnservice-worker-index.html. This is fine, because literally the only case where this matters is if a user is on one of those dynamic pages, and either 1) hard-refreshes, and 2) doesn't have a Service Worker, and refreshes. Those cases are so rare that the difference doesn't matter much.More troubling is having to manually manage this entire CSP mess, as well as a big regex to identify the dynamic URLs. But since we have a dev server to catch any mistakes I might make, I'm not too concerned. But it could be improved.