Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: loopAddBlankSlides incorrect documentation #7289

Conversation

rodrigovallades
Copy link
Contributor

@rodrigovallades rodrigovallades commented Jan 31, 2024

The SwiperOptions type definitions, which I believe is used to auto-generate the api website (https://swiperjs.com/swiper-api#param-loopAddBlankSlides), has incorrect information.

The API documentation states that loopAddBlankSlides defaults to false, but it actually defaults to true. This drove me crazy for some time (my implementation was broken), until I decided to take a look at the source code.

src/core/defaults.mjs - line 103

// loop
loop: false,
loopAddBlankSlides: true,
loopAdditionalSlides: 0,
loopPreventsSliding: true,

@rodrigovallades rodrigovallades changed the title fix: SwiperOptions loopAddBlankSlides documentation fix: SwiperOptions loopAddBlankSlides incorrect documentation Jan 31, 2024
@rodrigovallades rodrigovallades changed the title fix: SwiperOptions loopAddBlankSlides incorrect documentation fix: loopAddBlankSlides incorrect documentation Jan 31, 2024
@nolimits4web nolimits4web merged commit cbc3dba into nolimits4web:master Feb 5, 2024
@nolimits4web
Copy link
Owner

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants