Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom vesting commands #80

Merged
merged 3 commits into from
May 29, 2023
Merged

Custom vesting commands #80

merged 3 commits into from
May 29, 2023

Conversation

Lockwarr
Copy link
Contributor

New module(vestings) with a single functionality - adding a vesting account with the option to specify custom starting time, whereas the native cosmos-sdk's module for adding a vesting account on a running chain always sets the starting time to the current block time

@Lockwarr Lockwarr force-pushed the custom-vesting-commands branch 3 times, most recently from be69a69 to 5954fab Compare May 25, 2023 14:17
@Lockwarr Lockwarr force-pushed the custom-vesting-commands branch from 5954fab to 62c5640 Compare May 26, 2023 15:11
Copy link
Collaborator

@ivivanov ivivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated changes would be better to be in separate commit:
.proto formating
add the new protobuf formatting feature

ADR: why do we need this new module

app/keepers/keepers.go Outdated Show resolved Hide resolved
x/vestings/README.md Show resolved Hide resolved
x/vestings/types/types.go Outdated Show resolved Hide resolved
@Lockwarr Lockwarr force-pushed the custom-vesting-commands branch from 62c5640 to ed94b48 Compare May 29, 2023 13:21
chore: fix linter

chore: add adr for vestings module
@Lockwarr Lockwarr force-pushed the custom-vesting-commands branch from ed94b48 to 3a2efbe Compare May 29, 2023 13:26
@Lockwarr Lockwarr merged commit e4dbf48 into main May 29, 2023
@Lockwarr Lockwarr deleted the custom-vesting-commands branch May 29, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants