Overflow on fraction of duration #370
Conversation
| use crate::fractionable::Fractionable; | ||
| assert_eq!( | ||
| Coin::<SuperGroupTestC1>::new(30), | ||
| Coin::<SuperGroupTestC1>::new(3).safe_mul(&Percent::from_percent(1000)) | ||
| Fractionable::<u32>::checked_mul( |
There was a problem hiding this comment.
[everywhere] not sure we need the extended syntax when calling checked_mul. More concise and readable is if we call it on the first operand
There was a problem hiding this comment.
Are you sure the original code cannot be compiled?
| use crate::fractionable::Fractionable; | ||
| assert_eq!( | ||
| Coin::<SuperGroupTestC1>::new(30), | ||
| Coin::<SuperGroupTestC1>::new(3).safe_mul(&Percent::from_percent(1000)) | ||
| Fractionable::<u32>::checked_mul( |
There was a problem hiding this comment.
Are you sure the original code cannot be compiled?
| .try_into() | ||
| .expect("overflow computing a fraction of duration") | ||
| let d128: u128 = self.into(); | ||
| Fractionable::<Coin<C>>::checked_mul(d128, fraction) |
There was a problem hiding this comment.
Have you verified that the direct calling syntax does not work? We did not add more implementations so d128.checked_mul(fraction) should work fine
| Percent::from_permille(self.units().safe_mul(ratio)) | ||
| Fractionable::<Units>::checked_mul(self.units(), ratio).map(Self::from_permille) |
There was a problem hiding this comment.
again, I have to clue why the former calling syntax is not applicable anymore
maneva3
force-pushed
the
overflow_on_fraction_of_duration
branch
2 times, most recently
from
1de3926 to
e91e7a1
Compare
| where | ||
| A: Fractionable<U>; | ||
| A: Fractionable<U> + Display + Clone; |
There was a problem hiding this comment.
we should not require Display + Clone
There was a problem hiding this comment.
what is the motivation for that?
maneva3
force-pushed
the
overflow_on_fraction_of_duration
branch
2 times, most recently
from
f879640 to
b384923
Compare
maneva3
force-pushed
the
overflow_on_fraction_of_duration
branch
2 times, most recently
from
f2d5176 to
3e867a0
Compare
…mwasm_std::OverflowError
maneva3
force-pushed
the
overflow_on_fraction_of_duration
branch
from
5b81c33 to
2eeda67
Compare
No description provided.