Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty sidebar pulls the page content to the left #16

Closed
karamellpelle opened this issue Nov 10, 2020 · 5 comments
Closed

Empty sidebar pulls the page content to the left #16

karamellpelle opened this issue Nov 10, 2020 · 5 comments
Assignees
Labels
Category: Bug Fix The issue requires a bug fix Category: Feature The issue describes a feature request Priority: Medium Resolution: Completed Issue has been fixed and tested

Comments

@karamellpelle
Copy link

Nice template, thanks!

If I only use the config setting Content for sidebarLeftRow1,sidebarLeftRow2,sidebarLeftRow3 or sidebarLeftRow4, and there is no content in the sidebar (or all these are set to None), the page content is pulled all the way to the left, over the sidebar area. I guess this is wrong (at least I want the page content on the right side of the sidebar).

@karamellpelle karamellpelle changed the title Empty sidebar pulls the sidebar to the left Empty sidebar pulls the page content to the left Nov 10, 2020
@nomadjimbob nomadjimbob self-assigned this Nov 12, 2020
@nomadjimbob
Copy link
Owner

If you have no sidebar content (either in a page, or by setting all of the rows to None in the config) then the sidebar is not shown as there is nothing to show.

Are you saying that you want the theme to always show a sidebar, even when there is no content to show in the sidebar?

@karamellpelle
Copy link
Author

Yes, I always want a sidebar. Because some namespaces have a sidebar, and some don't. This makes the layout consistent for my site.

Also, the sidebar is still shown (as a colored frame) when there is no sidebar, but the page content is wrapped over it, at the top.

@karamellpelle
Copy link
Author

An easy solution to my problem is to create a sidebar with an empty character. Works well!

@nomadjimbob
Copy link
Owner

The current master now has the option to always show the sidebar (left and/or right) even when there is no content. The option is disabled by default not to break current installs.

The rouge sidebar overflow issue should also be fixed.

When tested over the next few days, an official release will be done

@nomadjimbob nomadjimbob added Category: Bug Fix The issue requires a bug fix Category: Feature The issue describes a feature request Priority: Medium Status: Needs Testing Issue has been fixed, needs testing before closure labels Nov 12, 2020
@nomadjimbob
Copy link
Owner

An easy solution to my problem is to create a sidebar with an empty character. Works well!

Yeah, as long as there is some kind of content present, then it will write out the sidebar code. Still a work around and not ideal for larger sites for how you want it to work. The current master now has an option to always show the sidebar, even when there is no content.

@nomadjimbob nomadjimbob added Resolution: Completed Issue has been fixed and tested and removed Status: Needs Testing Issue has been fixed, needs testing before closure labels Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bug Fix The issue requires a bug fix Category: Feature The issue describes a feature request Priority: Medium Resolution: Completed Issue has been fixed and tested
Projects
None yet
Development

No branches or pull requests

2 participants