-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] / [Feature request]: Working __site_width__ to customize maximum page width for better readability #22
Comments
These style settings do not appear to be from the Mikio template so I am not sure where they have come from. The template also has language data for its placeholders so there should not be any placeholders that Mikio supports starting, or ending with "__". Mikio always uses 100% view width. I can add an option for a max-width, which is what Bootstrap does, centring the site content container on the site. (ie if the site content has a max width of 800 pixels, and the window is 1000 pixels wide, there will be 100 pixel whitespace each site of the site content. |
Hey nomad, :) thanks for your support. That said you may be absolutely right about your assumption - this is backed up by the following observation, the behavior however is reproducable.
That said I'd love your suggestion of adding the option for a max-width based on e.g. rem or px. 👍 Best regards :) |
The next release will add/support the site width setting under the Template Style Settings admin panel. An example of it working is below. Note that I have set the width to smaller than usual to highlight the it on a wide viewport The next release should be available in a day or 2 once I do a little more testing |
Hey nomad,
thanks again for the great work on the template. This one could be a bug or feature request:
In the Template Style Settings a site_width can be set (default 73%) but currently doesn't seem to have an effect.
https://i.imgur.com/vtoAcOe.png
I was expecting this to limit the total site width, as on bigger screens text readability suffers a lot if too wide.
Thus I attempted multiple settings (e.g. 66%, 33%, 1000px, 30rem) but saw no changes no matter the input value: https://i.imgur.com/USKn2vr.png
A draft of what I thought it'd look like is this: https://i.imgur.com/YoEs9tS.png
The text was updated successfully, but these errors were encountered: