Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing a section of a page corrupts the remainder of the markup #3

Closed
nomadjimbob opened this issue Jul 14, 2020 · 2 comments
Closed
Labels
Category: Bug Fix The issue requires a bug fix Priority: Critical Resolution: Completed Issue has been fixed and tested

Comments

@nomadjimbob
Copy link
Owner

As per the title.

Editing the entire page works fine.

@nomadjimbob nomadjimbob added Priority: Critical Category: Bug Fix The issue requires a bug fix Status: Work in Progress Issue is being investigated/fixed labels Jul 14, 2020
@nomadjimbob
Copy link
Owner Author

This is caused by the simple_html_dom library

contains the post content of the page and includes new line characters. simple_html_dom mangles this value by removing the new line characters from the value

nomadjimbob added a commit that referenced this issue Jul 14, 2020
@nomadjimbob
Copy link
Owner Author

Modified the library by commenting out lines 2112-2114 in the parse_attr function

$value = str_replace("\r", '', $value);
$value = str_replace("\n", '', $value);

@nomadjimbob nomadjimbob added Resolution: Completed Issue has been fixed and tested and removed Status: Work in Progress Issue is being investigated/fixed labels Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bug Fix The issue requires a bug fix Priority: Critical Resolution: Completed Issue has been fixed and tested
Projects
None yet
Development

No branches or pull requests

1 participant