Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dokuwiki "Stick" version #33

Closed
NoralK opened this issue Aug 1, 2021 · 1 comment
Closed

Dokuwiki "Stick" version #33

NoralK opened this issue Aug 1, 2021 · 1 comment
Assignees
@nomadjimbob
Labels
Category: Bug Fix The issue requires a bug fix

Comments

@NoralK
Copy link

NoralK commented Aug 1, 2021

Greetings,

When using the stick version of Dokuwiki there is an issue with css.php for both the template and the plugin. In both scenarios strpos is the culprit. When I take

strpos($cssFile, $baseDir) === 0 &&

out of the if statements then all works as expected.
@nomadjimbob nomadjimbob self-assigned this Aug 10, 2021
@nomadjimbob nomadjimbob added the Category: Bug Fix The issue requires a bug fix label Aug 10, 2021
nomadjimbob added a commit that referenced this issue Aug 10, 2021
@nomadjimbob
fixed path check on windows #33
fd3ef33
@nomadjimbob
Copy link
Owner

Apologies. The issue is due to directory separators being different on Mac/Linux compared to Windows. I did not account for this when doing path comparatives. I have fixed in the 2021-08-11 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nomadjimbob nomadjimbob

Labels
Category: Bug Fix The issue requires a bug fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NoralK @nomadjimbob