Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong name for breadcrumbs images #45

Closed
babudro opened this issue Sep 2, 2022 · 1 comment
Closed

Wrong name for breadcrumbs images #45

babudro opened this issue Sep 2, 2022 · 1 comment
Assignees
Labels
Category: Bug Fix The issue requires a bug fix

Comments

@babudro
Copy link

babudro commented Sep 2, 2022

The text in lang/en/settings.php says to name the image breadcrumb.png, but this is not correct. Looking in the code I discovered that the images should be named youarehere-prefix.png and youarehere-sep.png.

The four lines that mention this are these:

lang/en/settings.php:55:
$lang['breadcrumbPrefixText'] = 'Replacement breadcrumb prefix text. Use can use an image by uploading breadcrumb.png to the templates images directory';

lang/en/settings.php:57:
$lang['breadcrumbSepText'] = 'Replacement breadcrumb seperator text. Use can use an image by uploading breadcrumb.png to the templates images directory';;

lang/en/settings.php:62:
$lang['youareherePrefixText'] = 'Replacement you are here prefix text. Use can use an image by uploading breadcrumb.png to the templates images directory';

lang/en/settings.php:64:
$lang['youarehereSepText'] = 'Replacement you are here seperator text. Use can use an image by uploading breadcrumb.png to the templates images directory';;

Also, a minor grammatical point: The word templates should be possessive, i.e., template's images directory.

@nomadjimbob nomadjimbob added the Category: Bug Fix The issue requires a bug fix label Sep 2, 2022
@nomadjimbob nomadjimbob self-assigned this Sep 2, 2022
@nomadjimbob
Copy link
Owner

Thank you for reporting this. It has now been fixed, and a new release will be on Dokuwiki in the next few days.

nomadjimbob added a commit that referenced this issue Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bug Fix The issue requires a bug fix
Projects
None yet
Development

No branches or pull requests

2 participants