Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chinese language, fix the problem that some settings are invalid in Chinese language environment. #81

Closed
Little-Data opened this issue Jun 20, 2024 · 2 comments
Labels
Category: Bug Fix The issue requires a bug fix Priority: High

Comments

@Little-Data
Copy link
Contributor

I translated the files in the "lang" folder and "conf" folder into Chinese.

The files in the "lang" folder work perfectly.
The files in the "conf" folder invalidate some settings. After changing to English, it works fine.

The files in the "conf-zh-cn" folder are translated files, and when I put them in the "conf" folder to test it, the above problem occurs.
I hope the "conf" folder supports multiple languages.

I submitted the file changes to PR

Please check.

@nomadjimbob
Copy link
Owner

Mikio currently does not support languages other than English for strings in the conf directory files as the code does direct comparisons of the string values.

I will need to add in the language keys for this and modify the code to instead compare the conf values against the language keys to confirm the setting values.

I will work on this when I get a chance

@nomadjimbob
Copy link
Owner

Comparing against template strings is now implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bug Fix The issue requires a bug fix Priority: High
Projects
None yet
Development

No branches or pull requests

2 participants