Fix isDragging set to true even when a non Mosaic Window is dragged #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For some reason CircleCI seems not to be reporting anything :/ |
|
That's weird. The build shows up on circle - looking into it. |
|
Thanks for your quick feedback 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
isDraggingprops of RootDropTargetsClass (and-draggingcss class) is set to true even when the dragged item is not aMosaicDragType.WINDOW. This can be an issue as I have otherDropTargetfromreact-dndin my app, and when I drag anything else that is not a Window, RootDropTargetsClass is blocking the drag as it's displayed as a block.The PR ensure that the container remains hidden when the dragged item is not a
MosaicDragType.WINDOW.Reviewers should focus on:
Is this breaking anything? :) Tested on the demo and everything looks still good.
Screenshot
N/A