Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load readme as long description in setup.py #349

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

mcembalest
Copy link
Collaborator

@mcembalest mcembalest commented Nov 8, 2024

Important

Load long_description from README.md and bump version to 3.3.1 in setup.py.

  • Setup Configuration:
    • Load long_description from README.md in setup.py instead of using description.
  • Version Update:
    • Bump version from 3.3.0 to 3.3.1 in setup.py.

This description was created by Ellipsis for 78c3500. It will automatically update as commits are pushed.

setup.py Show resolved Hide resolved
@mcembalest mcembalest changed the title bump v3.3.1 and load readme as long description in setup.py load readme as long description in setup.py Nov 8, 2024
Copy link
Collaborator

@bmschmidt bmschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmschmidt bmschmidt changed the title load readme as long description in setup.py docs: load readme as long description in setup.py Nov 8, 2024
@bmschmidt bmschmidt changed the title docs: load readme as long description in setup.py fix: load readme as long description in setup.py Nov 8, 2024
@mcembalest mcembalest dismissed zanussbaum’s stale review November 8, 2024 18:31

addressed this comment, no longer bumping version in this pr

@mcembalest mcembalest merged commit 4d315e9 into main Nov 8, 2024
3 checks passed
@bmschmidt
Copy link
Collaborator

Noting @mcembalest I added fix to the PR title here, which is necessary to make it actually trigger the release please note

This was referenced Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants