move testing to vitest #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @bmschmidt and the rest of your teammates on |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
tests/project.test.ts
Outdated
| 'Index actually builds and is returned from server', | ||
| async () => { | ||
| await project.wait_for_lock(); | ||
| index = (await project.indices())[0]; |
There was a problem hiding this comment.
Add error handling for the API call to project.indices() to ensure robustness in case of failures.
bmschmidt
force-pushed
the
11-01-move_testing_to_vitest
branch
from
da4f0e2 to
ecd2422
Compare
| @@ -1,7 +1,6 @@ | |||
| import { test } from 'uvu'; | |||
| import { test } from 'vitest'; | |||
There was a problem hiding this comment.
Suggested change
| import { test } from 'vitest'; | |
| import { test, expect } from 'vitest'; |
| @@ -16,7 +15,7 @@ test('Embed a point from an env token', async () => { | |||
| // Pulling the API key from env variable. | |||
| const values = await embed(strings); | |||
There was a problem hiding this comment.
API calls should include error handling to manage potential failures.
RLesser
reviewed
Nov 1, 2024
RLesser
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still failing a test on wait_for_project_lock.
Important
Migrate testing framework from
uvutovitest, updating test scripts, dependencies, and test files accordingly.uvuwithvitestinpackage.jsontest scripts.uvuand related dependencies; addvitest.vitest.config.tsfor configuration..jsto.ts(e.g.,arrow.test.jstoarrow.ts).uvutovitestinembedding.test.ts,neighbors.test.ts,project.test.ts, anduser.test.ts.assertwithexpectin test assertions.project.test.jsand replace withproject.test.tswith updated test cases.This description was created by
for ecd2422. It will automatically update as commits are pushed.