Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GET /articles/{slug}/comments #164

Open
nomisRev opened this issue Sep 25, 2023 · 2 comments
Open

GET /articles/{slug}/comments #164

nomisRev opened this issue Sep 25, 2023 · 2 comments
Assignees
Labels
hacktoberfest Tickets belonging to hacktoberfest

Comments

@nomisRev
Copy link
Owner

nomisRev commented Sep 25, 2023

In order to fully support articles we need to implement a GET article comments for slug,
according to following OpenAPI Spec.

/articles/{slug}/comments:
    get:
      tags:
        - Comments
      summary: Get comments for an article
      description: Get the comments for an article. Auth is optional
      operationId: GetArticleComments
      parameters:
        - name: slug
          in: path
          description: Slug of the article that you want to get comments for
          required: true
          schema:
            type: string
      responses:
        '200':
          $ref: '#/components/responses/MultipleCommentsResponse'
        '401':
          $ref: '#/components/responses/Unauthorized'
        '422':
          $ref: '#/components/responses/GenericError'
  1. Add missing domain objects MultipleCommentsResponse if it doesn't exist.
  2. Implement getCommentsForSlug in ArticlePersistence by adding the corresponding SQL to SqlDelight
  3. Create articles.kt in routes if does not exist, implement the GET route using ArticlePersistence
  4. Add test that verifies the behavior works

Please assign yourself to this ticket before starting, and if you run into any issues please raise a PR so I can provide help and support directly in the code.

Thank you in advance for your interest in the project! Happy hacktoberfest!

@nomisRev nomisRev added the hacktoberfest Tickets belonging to hacktoberfest label Sep 26, 2023
@arioston
Copy link
Contributor

hi @nomisRev , can I work on this? I may also help with #165

@nomisRev
Copy link
Owner Author

Hey @arioston,
Please do! 🙏
Sorry for the late response, I needed some off time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Tickets belonging to hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants