Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POST /articles/{slug}/comments #165

Open
nomisRev opened this issue Sep 25, 2023 · 4 comments
Open

POST /articles/{slug}/comments #165

nomisRev opened this issue Sep 25, 2023 · 4 comments
Assignees
Labels
hacktoberfest Tickets belonging to hacktoberfest

Comments

@nomisRev
Copy link
Owner

nomisRev commented Sep 25, 2023

In order to fully support articles we need to implement a POST article comments for slug,
according to following OpenAPI Spec.

    post:
      tags:
        - Comments
      summary: Create a comment for an article
      description: Create a comment for an article. Auth is required
      operationId: CreateArticleComment
      parameters:
        - name: slug
          in: path
          description: Slug of the article that you want to create a comment for
          required: true
          schema:
            type: string
      requestBody:
        $ref: '#/components/requestBodies/NewCommentRequest'
      responses:
        '200':
          $ref: '#/components/responses/SingleCommentResponse'
        '401':
          $ref: '#/components/responses/Unauthorized'
        '422':
          $ref: '#/components/responses/GenericError'
      security:
        - Token: []
      x-codegen-request-body-name: comment
  1. Add missing domain objects NewCommentRequest and SingleCommentResponse if it doesn't exist.
  2. Implement insertCommentForArticleSlug in ArticlePersistence by adding the corresponding SQL to SqlDelight
  3. Create articles.kt in routes if does not exist, implement the POST route using ArticlePersistence
  4. Add test that verifies the behavior works

Please assign yourself to this ticket before starting, and if you run into any issues please raise a PR so I can provide help and support directly in the code.

Thank you in advance for your interest in the project! Happy hacktoberfest!

@nomisRev nomisRev added the hacktoberfest Tickets belonging to hacktoberfest label Sep 26, 2023
@Kaaveh
Copy link
Contributor

Kaaveh commented Oct 29, 2023

Hey @nomisRev
I'd like to work on this task.

@nomisRev
Copy link
Owner Author

Hey @Kaaveh,
Please do! Sorry for the late response, I needed some off time.

@Kaaveh
Copy link
Contributor

Kaaveh commented Dec 15, 2023

Hey @nomisRev
Thank you for assigning me to this task. Unfortunately, I am currently facing some issues that prevent me from working on side projects. I estimate that I will be able to work on this feature in the next couple of months.
Is that okay?

@Kaaveh
Copy link
Contributor

Kaaveh commented Jan 20, 2024

Hmmm, It seems that the task has been completed.
@nomisRev @arioston

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Tickets belonging to hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants