Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-http-proxy bases proxy implementation (default) throws an ECONNRESET error when a timeout occurs or the client aborts the requests #77

Closed
nonblocking opened this issue May 5, 2021 · 0 comments · Fixed by #83
Closed

node-http-proxy bases proxy implementation (default) throws an ECONNRESET error when a timeout occurs or the client aborts the requests #77

nonblocking opened this issue May 5, 2021 · 0 comments · Fixed by #83
Assignees
@nonblocking
Labels
bug Something isn't working

Comments

@nonblocking
Copy link
Owner

nonblocking commented May 5, 2021 •
edited
Loading

Possible cause: http-party/node-http-proxy#1455

Desired behaviour:

  • Throw a ESOCKETTIMEDOUT if a timeout occurs
  • Ignore/swallow client aborts

(Basically the behaviour of the "request" based proxy)
@nonblocking nonblocking added the bug Something isn't working label May 5, 2021
@nonblocking nonblocking self-assigned this May 5, 2021
nonblocking added a commit that referenced this issue May 6, 2021
@nonblocking
Allow it to disable connection keep-alive; mitigates #77
f004af5
@nonblocking nonblocking changed the title node-http-proxy based proxy implementation fails when the server resets a keep alive connection node-http-proxy proxy implementation (default) throws an ECONNRESET error when a timeout occurs or the client aborts the requests Sep 2, 2021
@nonblocking nonblocking changed the title node-http-proxy proxy implementation (default) throws an ECONNRESET error when a timeout occurs or the client aborts the requests node-http-proxy base proxy implementation (default) throws an ECONNRESET error when a timeout occurs or the client aborts the requests Sep 2, 2021
@nonblocking nonblocking changed the title node-http-proxy base proxy implementation (default) throws an ECONNRESET error when a timeout occurs or the client aborts the requests node-http-proxy bases proxy implementation (default) throws an ECONNRESET error when a timeout occurs or the client aborts the requests Sep 2, 2021
nonblocking added a commit that referenced this issue Sep 2, 2021
@nonblocking
Fixed the error handling for the node-http-proxy based HTTP proxy:
d76fc9d 
 * If the client aborts the request no error message is logged any more
 * If a proxy request timeout occurs, a proper error messages is logged instead of ECONNRESET
 * If the proxy WebSocket request fails, the error is processed properly

Fixes #77
@nonblocking nonblocking mentioned this issue Sep 2, 2021
Merged
nonblocking added a commit that referenced this issue Sep 2, 2021
@nonblocking
Fixed the error handling for the node-http-proxy based HTTP proxy: (#83)
e123f9f 
* If the client aborts the request no error message is logged any more
* If a proxy request timeout occurs, a proper error messages is logged instead of ECONNRESET
* If the proxy WebSocket request fails, the error is processed properly

Fixes #77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nonblocking nonblocking

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed the error handling for the node-http-proxy based HTTP proxy nonblocking/mashroom
1 participant
@nonblocking