Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Do you like music visualization? #63

Closed
alex2wong opened this issue Sep 9, 2019 · 2 comments
Closed

PR: Do you like music visualization? #63

alex2wong opened this issue Sep 9, 2019 · 2 comments

Comments

@alex2wong
Copy link

Thank you for providing such good extension~~ I suppose we can add some more feature like music visualization. I've made one yesterday, tested locally. If you think it is OK, I'd like to send a PR.

snapshot as follows:
vscode_vudio

Technically, vudio.js was imported for audio visualization. Current issue is that I can NOT get song cover from existing request API, could you guys just add a cover img url attr for song API ? then I can rotate it in the circular : )

@nondanee
Copy link
Owner

nondanee commented Sep 9, 2019

Related issue #56
Honestly, I have no plan to add UI elements to webview page
Thanks, anyway
You can package your customized version to .vsix and install for personal use

Cover img url will be added to song object very soon : )

@alex2wong
Copy link
Author

Sure, thanks a lot : )
Actually this kind of feature can be optional, user can enable/disable it by controllers or keyboard shortcut. It cost some GPU/memory resource indeed and can attract unnecessary attention.

Looking forward the cover img url, thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants