Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for MacOS #20

Merged
merged 3 commits into from
Aug 19, 2018
Merged

Adding support for MacOS #20

merged 3 commits into from
Aug 19, 2018

Conversation

fr0zn
Copy link
Contributor

@fr0zn fr0zn commented Aug 17, 2018

Correctly checking for all dependencies required on MacOS. Recommending the user to force the linkage of e2fsprogs, which will be linked under /usr/local/sbin. (Maybe an export PATH="/usr/local/sbin:$PATH is needed for some users)

@nongiach
Copy link
Owner

Oups, my bad I didn't merge #17

now we have two pull request doing the same thing :/
I will test if your pull request works on debian and I will merge it because it looks more complete than the other one. Can you confirm that you tested with several options several times?
Thx and great work you both.

For the distribution function It would be nice to not rename Darwin to macos, I don't see the point of doing it, is there a reason?
Can you take a look at this: 9e534ee

Thx.

@fr0zn
Copy link
Contributor Author

fr0zn commented Aug 18, 2018

Ok, I decided not to rename darwin. I couldn't find a way to make -serial stdio -monitor /dev/null work on macOS. Getting -monitor /dev/null: 'serial' is not a valid char driver name. That's why I decided to erase that option in darwin in the first place.

On the last commit I found a way to solve that issue, setting -monitor to null (without dev). That change needs to be checked against other linux distributions.

Also:
From the man page: -serial and -monitor is set to stdio by default in non graphical mode.

@nongiach
Copy link
Owner

nice, I'm gonna check this out

@nongiach nongiach merged commit ad41778 into nongiach:master Aug 19, 2018
@nongiach
Copy link
Owner

Merged!
The opensource community thanks you for your service.
Do you have some feedback about some things that we can improve to ease pull requests?
For example, I know that we should have an automated unit test ^^
Thx

@nongiach nongiach mentioned this pull request Aug 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants