Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ivy as a completion back end option #51

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

abo-abo
Copy link

@abo-abo abo-abo commented Apr 17, 2015

  • smex.el (smex-completion-method): New defcustom. Leave ido as the
    default.
    (smex-auto-update):
    (smex-save-file):
    (smex-history-length):
    (smex-prompt-string):
    (smex-flex-matching): No need to specify group.
    (smex-map): New defvar. Users can cutomize this in a more robust way.
    (smex-prepare-ido-bindings): Update.
    (smex-completing-read): Dispatch on smex-completion-method'. (smex-initialize): Update. (smex-do-with-selected-item): Dispatch onsmex-completion-method'.

* smex.el (smex-completion-method): New defcustom. Leave ido as the
  default.
(smex-auto-update):
(smex-save-file):
(smex-history-length):
(smex-prompt-string):
(smex-flex-matching): No need to specify group.
(smex-map): New defvar. Users can cutomize this in a more robust way.
(smex-prepare-ido-bindings): Update.
(smex-completing-read): Dispatch on `smex-completion-method'.
(smex-initialize): Update.
(smex-do-with-selected-item): Dispatch on `smex-completion-method'.
@joedicastro
Copy link

👍

@kaushalmodi
Copy link

Looking forward to this being pulled.

@goofansu
Copy link

👍

@PythonNut
Copy link

@nonsequitur when this is merged, it's going to be awesome!

@jasonm23
Copy link

Please merge this, it's excellent! 👍

@ryepesg
Copy link

ryepesg commented Jan 15, 2016

👍

@PythonNut
Copy link

Out of curiosity, what does smex do that counsel-M-x doesn't?

@kaushalmodi
Copy link

@PythonNut counsel misses the command ranking that smex does. For example, with smex, when you call counsel-M-x, you will see the last used command top most in the list. Without smex, you will just get an alphabetically sorted list.

@zakkak
Copy link

zakkak commented Feb 23, 2016

👍

1 similar comment
@iffsid
Copy link

iffsid commented Mar 4, 2016

👍

@mrwacky42
Copy link

@abo-abo - Is there any particular reason you removed :group from the defcustom function calls?

@tumashu
Copy link

tumashu commented Aug 21, 2016

it's excellent! suggest merge

@Trevoke
Copy link

Trevoke commented Aug 30, 2016

I would be very grateful if this got merged.

@kaushalmodi
Copy link

@nonsequitur Hello?

@Trevoke
Copy link

Trevoke commented Aug 30, 2016

I just took a (granted fairly quick) look through the gists, inf-ruby and this repo, and I see no activity from @nonsequitur in quite a long time. I don't know if he or she is alive, frankly. We might need to create a fork for this code so we can continue maintaining it.

Maybe we shouldn't jump the shark, though. I know nothing of this person.

@kaushalmodi
Copy link

@Trevoke Well, @nonsequitur last had activity last July, and this issue was opened in April last year (16 months ago). Looks like the maintainer is somehow not interested in this.

@jasonm23
Copy link

Consider counsel-M-x?

You can use flx with ivy as per this config

http://oremacs.com/2016/01/06/ivy-flx/

@Trevoke
Copy link

Trevoke commented Aug 31, 2016

Sure, I can try it. Where can I find counsel-M-x ? I tried installing
counsel through the package manager, maybe that's not good enough?

On Tue, Aug 30, 2016 at 7:09 PM Jason Milkins notifications@github.com
wrote:

Consider counsel-M-x?

You can use flx with ivy as per this config

http://oremacs.com/2016/01/06/ivy-flx/


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#51 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAEJSZJjaKgJ8n3sKzUBEMf1ley24f9Bks5qlLgwgaJpZM4EC4yS
.

@kaushalmodi
Copy link

kaushalmodi commented Aug 31, 2016

@Trevoke Installing the counsel package is all you need. Then M-x counsel-M-x should work.

@asmeurer
Copy link

I just tried counsel, but I was disappointed that the default completions when I type M-x are ordered alphabetically, instead of by most recently used. Maybe I need to configure something?

@Trevoke
Copy link

Trevoke commented Aug 31, 2016

If you bind counsel-M-x to M-x then you should be fine:

image

@Trevoke
Copy link

Trevoke commented Aug 31, 2016

@kaushalmodi Got it. I ran into an error because I didn't have swiper installed.

@tumashu
Copy link

tumashu commented Aug 31, 2016

@asmeurer Install smex , counsel-M-x will use it to sort will recent used

@asmeurer
Copy link

asmeurer commented Sep 1, 2016

Ah. I had originally left smex enabled, but got some error about it (I'll have to check what it was on my other computer tomorrow, some undefined variable error I think), so I disabled it.

@kaushalmodi
Copy link

@Trevoke Yup, installing it using the in-built package manager would have done it automatically for you. From counsel.el:

;; Package-Requires: ((emacs "24.3") (swiper "0.8.0"))

@asmeurer
Copy link

asmeurer commented Sep 1, 2016

Ah. I had originally left smex enabled, but got some error about it (I'll have to check what it was on my other computer tomorrow, some undefined variable error I think), so I disabled it.

"Symbol's value as variable is void: smex-initialized-p"

If I manually execute (setq smex-initalized-p t) it works (and things are in the right order).

@asmeurer
Copy link

asmeurer commented Sep 1, 2016

Oh, I see. I've been using the branch from #12. CC @haxney I guess removing smex-initialize in that PR breaks counsel compatibility (and it looks like I already noticed this two years ago smh).

@joca-bt
Copy link

joca-bt commented Jul 10, 2017

@nonsequitur please merge this, it's very helpful!

@tumashu
Copy link

tumashu commented Jul 10, 2017

In my opinion, if you are a ivy user, you should use counsel-M-x instead of smex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.