Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locale and menu adjustments #127

Closed
wants to merge 10 commits into from
Closed

Conversation

SwissalpS
Copy link
Contributor

builds up on #126 adjusting some strings in de, es and fr.

also removes some menu items.

Every other string starts with a capital. Let's do it here (Preferences
Dialog) too.
Open -> New tab
Delete -> Close tab
except danish (da.po) because some chars
seem to be incompatible.
- 'edit tab name' is not needed, user can
just as easily do so with the 'preferences'
action. (in both 'edit' and 'context menu')

- 'quit' in context menu is an unusual choice. It's easier to click the
close button of the window and if that doesn't exist, there is the
normal 'File -> Quit' way.
tab -> pestaña
@nonstop
Copy link
Owner

nonstop commented Sep 9, 2022

Translations are fine.
Do not remove "Quit" and "Set tab name". I use them both.
Remove changes in termit.c.

@SwissalpS
Copy link
Contributor Author

do you use 'set tab name' in both the edit menu and the context menu?

commit 141b1b8
Author: Luke aka SwissalpS <Luke@SwissalpS.ws>
Date:   Fri Sep 9 14:36:13 2022 +0200

    Create README.md

commit 801d30f
Author: Luke aka SwissalpS <Luke@SwissalpS.ws>
Date:   Fri Sep 9 14:01:31 2022 +0200

    combine github workflows

commit df42e46
Author: Luke aka SwissalpS <Luke@SwissalpS.ws>
Date:   Fri Sep 9 13:50:53 2022 +0200

    Update build.yml

commit 495654f
Author: Luke aka SwissalpS <Luke@SwissalpS.ws>
Date:   Fri Sep 9 13:45:44 2022 +0200

    Update build.yml

commit 117312b
Author: Luke aka SwissalpS <Luke@SwissalpS.ws>
Date:   Fri Sep 9 13:43:57 2022 +0200

    Update build.yml

commit 601653a
Author: Luke aka SwissalpS <Luke@SwissalpS.ws>
Date:   Fri Sep 9 13:28:02 2022 +0200

    Update build.yml

commit 517589c
Author: Luke aka SwissalpS <Luke@SwissalpS.ws>
Date:   Fri Sep 9 13:24:37 2022 +0200

    Update build.yml

commit 58ba59d
Author: Luke aka SwissalpS <Luke@SwissalpS.ws>
Date:   Fri Sep 9 13:21:17 2022 +0200

    Update build.yml

commit 934b55c
Author: Luke aka SwissalpS <Luke@SwissalpS.ws>
Date:   Fri Sep 9 13:15:04 2022 +0200

    Update build.yml

commit 6c05195
Author: Luke aka SwissalpS <Luke@SwissalpS.ws>
Date:   Fri Sep 9 13:13:52 2022 +0200

    Update build.yml

commit 08921e7
Author: Luke aka SwissalpS <Luke@SwissalpS.ws>
Date:   Fri Sep 9 13:12:09 2022 +0200

    Update build.yml

commit 93efc58
Author: Luke aka SwissalpS <Luke@SwissalpS.ws>
Date:   Fri Sep 9 13:09:19 2022 +0200

    Update build.yml

commit 377530e
Author: Luke aka SwissalpS <Luke@SwissalpS.ws>
Date:   Fri Sep 9 13:07:19 2022 +0200

    Update build.yml

commit e45e355
Author: Luke aka SwissalpS <Luke@SwissalpS.ws>
Date:   Fri Sep 9 12:36:47 2022 +0200

    Squashed commit of the following:

    commit 2f33e7d
    Author: Luke aka SwissalpS <Luke@SwissalpS.ws>
    Date:   Fri Sep 9 12:24:46 2022 +0200

        tweak workflow 2

    commit 2c0c178
    Author: Luke aka SwissalpS <Luke@SwissalpS.ws>
    Date:   Fri Sep 9 12:20:37 2022 +0200

        version bump 3.1.1

    commit 528dd8a
    Author: Luke aka SwissalpS <Luke@SwissalpS.ws>
    Date:   Fri Sep 9 12:15:38 2022 +0200

        tweak build workflow

    commit 5a52e44
    Author: Luke aka SwissalpS <Luke@SwissalpS.ws>
    Date:   Fri Sep 9 12:03:51 2022 +0200

        adjust minimal cmake version

    commit c941257
    Author: Luke aka SwissalpS <Luke@SwissalpS.ws>
    Date:   Fri Sep 9 11:53:42 2022 +0200

        remove gcc check

    commit df5c6f2
    Author: SwissalpS <Luke@SwissalpS.ws>
    Date:   Thu Jul 28 16:17:12 2022 +0200

        adjust vte path

    commit 743aa6d
    Author: Luke aka SwissalpS <Luke@SwissalpS.ws>
    Date:   Fri Sep 9 11:40:45 2022 +0200

        Update build.yml

    commit 9c6f031
    Author: Luke aka SwissalpS <Luke@SwissalpS.ws>
    Date:   Fri Sep 9 11:36:58 2022 +0200

        Update build.yml

    commit 72c25dc
    Author: Luke aka SwissalpS <Luke@SwissalpS.ws>
    Date:   Fri Sep 9 11:29:00 2022 +0200

        second attempt

    commit 4c3198b
    Author: Luke aka SwissalpS <Luke@SwissalpS.ws>
    Date:   Fri Sep 9 11:16:12 2022 +0200

        first attempt
@SwissalpS
Copy link
Contributor Author

I've also added a readme.md and github workflows.
Added back all the removed menu items.

@SwissalpS
Copy link
Contributor Author

Thanks for writing this cool terminal, it has been my default for some years now :D

@nonstop
Copy link
Owner

nonstop commented Sep 9, 2022

Luke, I think the better way would be to split changes into several merges.
First patch - translations only.
Second patch - readme.md + build.yml.
Third patch - anything else. BTW I think it should not exist.

Thank you for your contribution.

@SwissalpS
Copy link
Contributor Author

yes, originally I had intended that. Then messed up.
I'll PR some split diffs.

@SwissalpS
Copy link
Contributor Author

closing to give #128 and #129 preference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants