Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSFS | NC | CLI | Add force_md5_etag option to account and bucket schema/create/update #7616

Closed
romayalon opened this issue Nov 23, 2023 · 8 comments
Assignees

Comments

@romayalon
Copy link
Contributor

Environment info

  • NooBaa Version: VERSION
  • Platform: Kubernetes 1.14.1 | minikube 1.1.1 | OpenShift 4.1 | other: specify

Actual behavior

  1. Currently a user can not set force_md5_etag property to account/bucket.

Expected behavior

  1. A user can not set force_md5_etag property to account/bucket.

Steps to reproduce

More information - Screenshots / Logs / Other output

@romayalon romayalon changed the title NSFS | NC | CLI | Add force_md5_etag option for account and bucket schema/create/update NSFS | NC | CLI | Add force_md5_etag option to account and bucket schema/create/update Nov 23, 2023
@nimrod-becker
Copy link
Contributor

Similar to what we have in regular deployments, add this option to an account config

@nimrod-becker
Copy link
Contributor

Ref to usage in namespace_fs

const md5_enabled = config.NSFS_CALCULATE_MD5 || (this.force_md5_etag ||

@shirady
Copy link
Contributor

shirady commented Mar 21, 2024

Hi,
I have an open question (also described in the PR comment).
If I have a general configuration with config.NSFS_CALCULATE_MD5 true.
Someone use the Manage NSFS CLI and decides that there is an account that will be a test account and creates it with --force_md5_etag false, what do we think that the value of md5_enabled should be?
Currently, the md5_enabled is still true.

cc: @romayalon @naveenpaul1 @nadavMiz

@nimrod-becker
Copy link
Contributor

nimrod-becker commented Mar 21, 2024

Specific Bucket/Account settings should override global settings

@shirady
Copy link
Contributor

shirady commented Mar 21, 2024

@nimrod-becker @nadavMiz it doesn't happen currently, do you want this change in the PR or a different one?
The current PR can be approved if we know it is a GAP to close (since it doesn't relate to the manage NSFS CLI).

@nadavMiz
Copy link
Contributor

@shirady I will add this in this PR

Copy link

This issue had no activity for too long - it will now be labeled stale. Update it to prevent it from getting closed.

@github-actions github-actions bot added the Stale label Jun 20, 2024
@shirady
Copy link
Contributor

shirady commented Jun 20, 2024

Closing, @nadavMiz fixed it in PR #7915.
Adding request validation label.
cc: @romayalon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants