Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSFS | NC | CLI | Add force_md5_etag option to account and bucket #7915

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

nadavMiz
Copy link
Contributor

@nadavMiz nadavMiz commented Mar 20, 2024

Explain the changes

  1. add an option to set force_md5_etag to both account bucket add and update in the nsfs manager cli. add this option to the account and bucket schema
  2. change force_md5_etag logic to first check if it is defined for the bucket, if not check if it is defined for the account, and if it isn't defined for both of them use default config.NSFS_CALCULATE_MD5.
  3. add an option to unset the force_md5_etag flag to both the account and bucket

Issues: Fixed #xxx / Gap #xxx

  1. NSFS | NC | CLI | Add force_md5_etag option to account and bucket schema/create/update  #7616

Testing Instructions:

  1. for bucket tests run: sudo npx jest test_nc_nsfs_bucket_cli.test.js
  2. for account tests run sudo npx jest test_nc_nsfs_account_cli.test.js
  3. for schema tests run sudo npx jest test_nc_nsfs_bucket_schema_validation.test.js
  • Doc added/updated
  • Tests added

src/manage_nsfs/manage_nsfs_help_utils.js Outdated Show resolved Hide resolved
src/manage_nsfs/manage_nsfs_help_utils.js Outdated Show resolved Hide resolved
src/cmd/manage_nsfs.js Outdated Show resolved Hide resolved
src/sdk/namespace_fs.js Outdated Show resolved Hide resolved
@nadavMiz nadavMiz requested a review from shirady March 25, 2024 09:20
src/sdk/namespace_fs.js Outdated Show resolved Hide resolved
src/sdk/namespace_fs.js Outdated Show resolved Hide resolved
src/sdk/namespace_fs.js Outdated Show resolved Hide resolved
src/sdk/namespace_fs.js Outdated Show resolved Hide resolved
@nadavMiz nadavMiz force-pushed the nsfs_manager_md5 branch 2 times, most recently from 6fadb68 to 0ed6609 Compare March 26, 2024 12:50
@nadavMiz nadavMiz requested a review from shirady March 26, 2024 13:01
src/cmd/manage_nsfs.js Outdated Show resolved Hide resolved
src/cmd/manage_nsfs.js Outdated Show resolved Hide resolved
@nadavMiz nadavMiz requested a review from shirady March 27, 2024 09:37
src/cmd/manage_nsfs.js Outdated Show resolved Hide resolved
src/cmd/manage_nsfs.js Outdated Show resolved Hide resolved
@nadavMiz nadavMiz force-pushed the nsfs_manager_md5 branch 3 times, most recently from ce908fe to 5c6bfbd Compare April 2, 2024 09:52
@nadavMiz nadavMiz force-pushed the nsfs_manager_md5 branch 4 times, most recently from ff447ed to f428f41 Compare April 3, 2024 14:46
Signed-off-by: nadav mizrahi <nadav.mizrahi16@gmail.com>
@nadavMiz nadavMiz merged commit dda6e59 into noobaa:master Apr 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants