NSFS | NC | Schema Changes (Mainly in nsfs_config_schema)

[shirady]

Environment info

• NooBaa Version: master
• Platform: NSFS | NC

Actual behavior

1. Currently we don't use strictify on nsfs_config_schema.
2. Currently we use ajv.validate(schema_name, object_to_validate) and it doesn't align with the avj documentation (here), please notice the comment "Best performance: compile and getSchema methods".

Expected behavior

1. Use strictify on nsfs_config_schema with additionalProperties: true.
2. Compile the validate function once and re-use it (details in the link attached above).

Steps to reproduce

1. none (internal change).

More information - Screenshots / Logs / Other output

Notes:
Currently, we would get errors trying to strictify on nsfs_config_schema. Partial things I found:

• The schema uses default keyword which we didn't have in our past schemas (probably need to edit strictify for that case).
• The schema uses description which is unknown keyword, and can be replaced with doc.
• The schema uses array, but does not use items under it.
• Might need general refactoring in the nsfs_config_schema so we would not get errors on strictify.

[shirady]

I plan to separate this fix into 2 PRs:

1. Align with avj documentation as mentioned (use compile and reuse validate function).
2. strictify on nsfs_config_schema with needed changes to the nsfs_config_schema.