NSFS | NC | Use avj compile
and Reuse validate
Function
#7887
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
compile
(which is done once) from thevalidate
(which is reuse).Issues:
ajv.validate(schema_name, object_to_validate)
and it doesn’t align with the avj documentation (here), please notice the comment “Best performance: compile and getSchema methods”:Note: it is a partial fix to #7874
Testing Instructions:
npx jest test_nc_nsfs_account_schema_validation.test.js
npx jest test_nc_nsfs_bucket_schema_validation.test.js
npx jest test_nc_nsfs_config_schema_validation.test.js