Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI | GAP | Ceph S3 Tests #7687

Merged
merged 1 commit into from
Jan 8, 2024
Merged

CI | GAP | Ceph S3 Tests #7687

merged 1 commit into from
Jan 8, 2024

Conversation

shirady
Copy link
Contributor

@shirady shirady commented Jan 2, 2024

Explain the changes

  1. In the NC Ceph tests (not NSFS) we had a “|| true” part after the run that was leftover from running it in the k8s job that we always wanted to complete successfully, in the new platform it is not relevant.

Issues:

  1. none, it closes a Gap I found during working on PR CI | Update Ceph S3 Tests (Commit Hash Number and Pending Lists) #7589

Testing Instructions:

  1. none (tested through the CI).
  2. If you wish to run it locally:
    make test-cephs3 CONTAINER_PLATFORM=linux/arm64
    make test-nsfs-cephs3 CONTAINER_PLATFORM=linux/arm64
    (I'm using the flag CONTAINER_PLATFORM because I have MacOS M1).
  • Doc added/updated
  • Tests added

Copy link
Member

@tangledbytes tangledbytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

In the NC Ceph tests (not NSFS) we had a “|| true” part after the run that was leftover from running it in the k8s job that we always wanted to complete successfully, in the new platform it is not relevant.

Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
@shirady shirady merged commit 8c796e8 into noobaa:master Jan 8, 2024
9 checks passed
@shirady shirady deleted the gap-ceph-test branch January 8, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants