Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI | Add a Printing to Test #7689

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Conversation

shirady
Copy link
Contributor

@shirady shirady commented Jan 2, 2024

Explain the changes

  1. Adding the values to be printed in the console before assert them in test_namespace_cache.js.

Issues: Fixed #xxx / Gap #xxx

  1. none

Testing Instructions:

  1. none (runs as a part of our CI).
  • Doc added/updated
  • Tests added

@shirady shirady self-assigned this Jan 2, 2024
@shirady shirady requested review from dannyzaken, a team and Neon-White and removed request for a team January 2, 2024 14:14
@Neon-White
Copy link
Contributor

Neon-White commented Jan 2, 2024

Ironically enough, the PR seems to work perfectly (as can be seen in the failed unit tests run) :)

2024-01-02T14:20:45.5271211Z �[32mJan-2 14:20:45.526�[35m [Endpoint/66] �[36m  [LOG]�[39m CONSOLE:: CHECK_VALUE: read_hub_time 1704205245518 err_trigger_time 1704205245518

The test fails because the values are identical, which could be because the read happens right afterward (lines 1189 and 1190), but could also be a logical problem

@shirady
Copy link
Contributor Author

shirady commented Jan 3, 2024

Ironically enough, the PR seems to work perfectly (as can be seen in the failed unit tests run) :)

2024-01-02T14:20:45.5271211Z �[32mJan-2 14:20:45.526�[35m [Endpoint/66] �[36m  [LOG]�[39m CONSOLE:: CHECK_VALUE: read_hub_time 1704205245518 err_trigger_time 1704205245518

The test fails because the values are identical, which could be because the read happens right afterward (lines 1189 and 1190), but could also be a logical problem

Exactly

Adding the values to be printed in the console before assert them in test_namespace_cache.js.

Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
@shirady shirady force-pushed the add-printings-to-test branch from eae46f3 to cb5277a Compare January 4, 2024 06:02
@shirady shirady merged commit d18db43 into noobaa:master Jan 4, 2024
9 checks passed
@shirady shirady deleted the add-printings-to-test branch January 4, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants