NC | NSFS | revoking --new_access_key and fixing access key update issues
#7697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranmauda
force-pushed
the
liran-fix-regenerate
branch
from
c49b3f2 to
0453447
Compare
romayalon
reviewed
Jan 7, 2024
liranmauda
force-pushed
the
liran-fix-regenerate
branch
from
0453447 to
2e67829
Compare
romayalon
reviewed
Jan 7, 2024
| //fixing the new_account_details for compare. | ||
| new_account_details = { ...new_account_details, ...new_account_details.nsfs_account_config }; | ||
| assert_account(account_symlink, new_account_details); | ||
| }); | ||
|
|
||
| it('should fail - cli update account new access_key wrong complexity', async () => { |
There was a problem hiding this comment.
wait but now you don't have a "should fail wrong complexity test"
There was a problem hiding this comment.
no, as we dont have the --new_access_key flag anymore, we removing this test, and the error is removed with it.
We do have a should fail - cli update account access_key wrong complexity for --access_key
and should fail - cli update account secret_key wrong complexity for --secret_key
…issues 1. revoking `--new_access_key` 2. fixing issue where `--regenerate` did not update the secret_key 3. fixing an issue where using `--access_key` without `--new_access_key` did not updated the symlink 4. updated the tests. Signed-off-by: liranmauda <liran.mauda@gmail.com>
liranmauda
force-pushed
the
liran-fix-regenerate
branch
from
2e67829 to
578b7c0
Compare
romayalon
approved these changes
Jan 7, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
--new_access_key--regeneratedid not update the secret_key--access_keywithout--new_access_keydid not updated the symlinkIssues: Fixed #xxx / Gap #xxx
--regenerateflag #7695Testing Instructions: